feat: add signer-key to synthetic pox events #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4329 +/- ##
===========================================
- Coverage 83.39% 71.84% -11.55%
===========================================
Files 435 435
Lines 309245 309254 +9
===========================================
- Hits 257886 222177 -35709
- Misses 51359 87077 +35718 ☔ View full report in Codecov by Sentry. |
hstove
approved these changes
Feb 1, 2024
| }} | ||
| }}) | ||
| "#, | ||
| extend_count = &args[0], | ||
| pox_addr = &args[1], | ||
| signer_key = &args.get(2).map_or("none".to_string(), |v| v.to_string()), |
There was a problem hiding this comment.
Suggested change
| signer_key = &args.get(2).map_or("none".to_string(), |v| v.to_string()), | |
| signer_key = &args.get(2).unwrap_or(&Value::none()), |
I'm still learning Rust, but my understanding is that to_string() is just calling the fmt::Display method, so to_string isn't necessary.
There was a problem hiding this comment.
unwrap_or wants the same type for both expressions
hstove
reviewed
Feb 1, 2024
| }} | ||
| }} | ||
| "#, | ||
| lock_amount = &args[0], | ||
| lock_period = &args[3], | ||
| pox_addr = &args[1], | ||
| start_burn_height = &args[2], | ||
| signer_key = &args.get(3).map_or("none".to_string(), |v| v.to_string()), |
There was a problem hiding this comment.
Ah we missed this - needs to be .get(4)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.