fix: incorrect arg index in synthetic event #4332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4332 +/- ##
==========================================
- Coverage 83.39% 73.76% -9.63%
==========================================
Files 435 435
Lines 309254 309278 +24
==========================================
- Hits 257892 228136 -29756
- Misses 51362 81142 +29780 ☔ View full report in Codecov by Sentry. |
kantai
approved these changes
Feb 1, 2024
zone117x
approved these changes
Feb 2, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4329 (just merged) one of the synthetic events used an incorrect arg index in the print for
stack-stx.I also noticed that
stack-aggregation-increaseandstack-aggregation-commithave diverged argument signatures --increase's third arg isreward-cycle-index, whereas-commit's third arg issigner-key. I've made a separatematchbranch to reflect this change.