Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to rubocop 1.4.2 and rubocop-performance 1.9.1 #225

Merged
merged 1 commit into from
Nov 30, 2020
Merged

updates to rubocop 1.4.2 and rubocop-performance 1.9.1 #225

merged 1 commit into from
Nov 30, 2020

Conversation

jmkoni
Copy link
Contributor

@jmkoni jmkoni commented Nov 30, 2020

Lots of updates over the holidays! There are three new performance rules that we are adding:

@jmkoni jmkoni merged commit 37a10d2 into master Nov 30, 2020
koic
koic reviewed Nov 30, 2020
View reviewed changes
config/base.yml
@@ -621,12 +621,18 @@ Naming/VariableName:
Enabled: true
EnforcedStyle: snake_case

Performance/ArraySemiInfiniteRangeSlice:
Enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, Performance/ArraySemiInfiniteRangeSlice cop will be removed in the future, so it is recommended to disable.
rubocop/rubocop-performance#198

This cop is disabled by default and it's best not to list it in config/base.yml in case it's removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic koic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmkoni @koic