Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to rubocop 1.4.2 and rubocop-performance 1.9.1 #225

Merged
merged 1 commit into from
Nov 30, 2020
Merged

updates to rubocop 1.4.2 and rubocop-performance 1.9.1 #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

## unreleased

* Update rubocop from 1.2.0 to [1.3.0](https://github.com/rubocop-hq/rubocop/releases/tag/v1.3.0) enabling:
* Update rubocop-performance from 1.8.1 to [1.9.1](https://github.com/rubocop-hq/rubocop-performance/releases/tag/v1.9.1) enabling:
* [`Performance/BlockGivenWithExplicitBlock`](https://github.com/rubocop-hq/rubocop-performance/pull/173)
* [`Performance/ConstantRegexp`](https://github.com/rubocop-hq/rubocop-performance/pull/174)
* [`Performance/ArraySemiInfiniteRangeSlice`](https://github.com/rubocop-hq/rubocop-performance/pull/175)
* Update rubocop from 1.2.0 to [1.4.2](https://github.com/rubocop-hq/rubocop/releases/tag/v1.4.2) enabling:
* [`Style/NilLambda`](https://github.com/rubocop-hq/rubocop/pull/9020)
* [`Lint/DuplicateBranch`](https://github.com/rubocop-hq/rubocop/pull/8404)

Expand Down
16 changes: 8 additions & 8 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ PATH
remote: .
specs:
standard (0.9.0)
rubocop (= 1.3.0)
rubocop-performance (= 1.8.1)
rubocop (= 1.4.2)
rubocop-performance (= 1.9.1)

GEM
remote: https://rubygems.org/
Expand All @@ -14,17 +14,17 @@ GEM
gimme (0.5.0)
method_source (1.0.0)
minitest (5.14.2)
parallel (1.20.0)
parallel (1.20.1)
parser (2.7.2.0)
ast (~> 2.4.1)
pry (0.13.1)
coderay (~> 1.1)
method_source (~> 1.0)
rainbow (3.0.0)
rake (13.0.1)
regexp_parser (1.8.2)
regexp_parser (2.0.0)
rexml (3.2.4)
rubocop (1.3.0)
rubocop (1.4.2)
parallel (~> 1.10)
parser (>= 2.7.1.5)
rainbow (>= 2.2.2, < 4.0)
Expand All @@ -33,10 +33,10 @@ GEM
rubocop-ast (>= 1.1.1)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 2.0)
rubocop-ast (1.1.1)
rubocop-ast (1.2.0)
parser (>= 2.7.1.5)
rubocop-performance (1.8.1)
rubocop (>= 0.87.0)
rubocop-performance (1.9.1)
rubocop (>= 0.90.0, < 2.0)
rubocop-ast (>= 0.4.0)
ruby-progressbar (1.10.1)
simplecov (0.19.0)
Expand Down
9 changes: 9 additions & 0 deletions config/base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,12 +621,18 @@ Naming/VariableName:
Enabled: true
EnforcedStyle: snake_case

Performance/ArraySemiInfiniteRangeSlice:
Enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, Performance/ArraySemiInfiniteRangeSlice cop will be removed in the future, so it is recommended to disable.
rubocop/rubocop-performance#198

This cop is disabled by default and it's best not to list it in config/base.yml in case it's removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info!


Performance/BigDecimalWithNumericArgument:
Enabled: true

Performance/BindCall:
Enabled: true

Performance/BlockGivenWithExplicitBlock:
Enabled: true

Performance/Caller:
Enabled: true

Expand All @@ -636,6 +642,9 @@ Performance/CollectionLiteralInLoop:
Performance/CompareWithBlock:
Enabled: true

Performance/ConstantRegexp:
Enabled: true

Performance/Count:
Enabled: true

Expand Down
4 changes: 2 additions & 2 deletions standard.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]

spec.add_dependency "rubocop", "1.3.0"
spec.add_dependency "rubocop-performance", "1.8.1"
spec.add_dependency "rubocop", "1.4.2"
spec.add_dependency "rubocop-performance", "1.9.1"

spec.add_development_dependency "bundler"
spec.add_development_dependency "minitest", "~> 5.0"
Expand Down