allow driving EL with LC #3865
Merged
allow driving EL with LC #3865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `--web3-url` launch argument to `nimbus_light_client` to enable driving the EL with the optimistic head obtained from LC sync protocol. This will keep issuing `newPayload` / `forkChoiceUpdated` requests for new blocks, marking them as optimistic. `ZERO_HASH` is reported as the finalized block for now.
|
Example: |
tersec
approved these changes
Jul 13, 2022
|
This needs rebasing now. |
zah
approved these changes
Jul 13, 2022
#3864 introduced a regression by turning on `requireAllFields` globally for JSON parsing. Certain endpoints such as `RestSyncInfo` have optional fields that do not parse correctly without additional changes. This is reverted for now to restore previous behaviour and unblock CI testing.
|
let's get a documentation page as well! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
--web3-urllaunch argument tonimbus_light_clientto enabledriving the EL with the optimistic head obtained from LC sync protocol.
This will keep issuing
newPayload/forkChoiceUpdatedrequests fornew blocks, marking them as optimistic.
ZERO_HASHis reported as thefinalized block for now.