Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Webpack Title #17935

Merged
merged 3 commits into from
Jul 1, 2022
Merged

Update Webpack Title #17935

merged 3 commits into from
Jul 1, 2022

Conversation

MichaelArestad
Copy link
Contributor

Issue: #17709

What I did

I updated the title to be "Storybook loading…". I think it might be better to actually say the name of the Storybook. @kylegach is that something that can be easily done?

How to test

TBD

@MichaelArestad MichaelArestad added maintenance User-facing maintenance tasks linear labels Apr 11, 2022
@MichaelArestad MichaelArestad self-assigned this Apr 11, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 11, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8bcf99e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@IanVS
Copy link
Member

IanVS commented Apr 11, 2022

I'm all for this! It always feels strange to see "Webpack app" in my vite project storybook. 😂

kylegach
kylegach approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@kylegach kylegach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

As far as using the brandTitle, that's a great idea, but I've heard talk of moving the non-color-related theme stuff into main.js in 7.0 after which it'll be a lot easier to do that.

Sorry. Just realized this is a draft PR. Feel free to ping me for a re-review, if warranted!

@MichaelArestad
Copy link
Contributor Author

@kylegach In that case, I think we should get this one in and then follow up post 7.0 to change it to the brandTitle.

@MichaelArestad MichaelArestad marked this pull request as ready for review April 12, 2022 14:23
@ndelangen ndelangen merged commit 4cfdbbf into next Jul 1, 2022
@ndelangen ndelangen deleted the update-webpack-title branch July 1, 2022 00:32
@shilman shilman mentioned this pull request Jul 2, 2022
Closed
@harish-sethuraman harish-sethuraman mentioned this pull request Jul 14, 2022
Closed
@artrasoft
Copy link

I'm all for this! It always feels strange to see "Webpack app" in my vite project storybook. 😂

"Webpack app" even though Webpack isn't involved. Strange

@jamigibbs jamigibbs mentioned this pull request Jan 20, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@kylegach kylegach kylegach approved these changes

Assignees

@MichaelArestad MichaelArestad

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MichaelArestad @IanVS @artrasoft @kylegach @ndelangen