Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize UsageRecord methods #693

Closed
wants to merge 1 commit into from
Closed

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Replace UsageRecord::create($params) (where $params must include a subscription_item key) with SubscriptionItem::createUsageRecord($id, $params).

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but technically it'd be better to add the new way to master and update the docs and such though

@ob-stripe
Copy link
Contributor Author

Approving but technically it'd be better to add the new way to master and update the docs and such though

Good point. I've added the method to the current branch and released it as 6.43.0. Will close this PR and amend #692 to remove UsageRecord::create.

@ob-stripe ob-stripe closed this Aug 9, 2019
@ob-stripe ob-stripe deleted the ob-usage-record branch August 9, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants