Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize UsageRecord methods #693

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/SubscriptionItem.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,27 @@ class SubscriptionItem extends ApiResource
{
const OBJECT_NAME = "subscription_item";

const PATH_USAGE_RECORDS = '/usage_records';

use ApiOperations\All;
use ApiOperations\Create;
use ApiOperations\Delete;
use ApiOperations\NestedResource;
use ApiOperations\Retrieve;
use ApiOperations\Update;

/**
* @param string|null $id The ID of the subscription item on which to create the usage record.
* @param array|null $params
* @param array|string|null $opts
*
* @return ApiResource
*/
public static function createUsageRecord($id, $params = null, $opts = null)
{
return self::_createNestedResource($id, static::PATH_USAGE_RECORDS, $params, $opts);
}

/**
* @param array|null $params
* @param array|string|null $options
Expand Down
23 changes: 0 additions & 23 deletions lib/UsageRecord.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,4 @@
class UsageRecord extends ApiResource
{
const OBJECT_NAME = "usage_record";

/**
* @param array|null $params
* @param array|string|null $options
*
* @return \Stripe\ApiResource The created resource.
*/
public static function create($params = null, $options = null)
{
self::_validateParams($params);
if (!array_key_exists('subscription_item', $params)) {
throw new Error\InvalidRequest("Missing subscription_item param in request", null);
}
$subscription_item = $params['subscription_item'];
$url = "/v1/subscription_items/$subscription_item/usage_records";
$request_params = $params;
unset($request_params['subscription_item']);

list($response, $opts) = static::_staticRequest('post', $url, $request_params, $options);
$obj = \Stripe\Util\Util::convertToStripeObject($response->json, $opts);
$obj->setLastResponse($response);
return $obj;
}
}
13 changes: 13 additions & 0 deletions tests/Stripe/SubscriptionItemTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,19 @@ public function testIsDeletable()
$this->assertInstanceOf(\Stripe\SubscriptionItem::class, $resource);
}

public function testCanCreateUsageRecord()
{
$this->expectsRequest(
'post',
'/v1/subscription_items/' . self::TEST_RESOURCE_ID . '/usage_records'
);
$resource = SubscriptionItem::createUsageRecord(self::TEST_RESOURCE_ID, [
'quantity' => 100,
'timestamp' => 12341234,
'action' => 'set',
]);
}

public function testCanListUsageRecordSummaries()
{
$resource = SubscriptionItem::retrieve(self::TEST_RESOURCE_ID);
Expand Down
35 changes: 0 additions & 35 deletions tests/Stripe/UsageRecordTest.php

This file was deleted.