-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dictionary blocks -WIP #2585
Conversation
@Clue88 right now I am JSON encoding the dictionary and outputing it as a string type. Does that suit your purposes? @meganindya It wasn't obvious to me where I would need to make any changes in the export code. Please advise. @pikurasa could you please provide JA for "get value" "set value" "show dictionary" and "dictionary"? (where value comes from keyword/value pair) Thx. |
@pikurasa also, "key", which we will need to distinguish from musical key. |
@walterbender Add a section to the guide as to how to use these blocks for ensembles. |
@walterbender sorry for running away unannounced. I was caught up heavily in school stuff. I checked the 6 new blocks — seem to be working fine. For export, the logic and graphics need to be totally separated, which didn't happen for the ensemble blocks and so those were pending. The way for export is to start by separating the "action" logic into a file in I can follow the changes to Meanwhile, are you planning more changes to |
@meganindya I deprecated a bunch of the ensemble blocks -- many are not needed any more. Let me merge this PR and when you have time, please make any necessary changes for export. I presume Heap will need similar changes? |
I had some trouble with the way heap blocks were implemented which was in conflict with the changes made to other blocks for separation of concerns. Hence, that was deferred. The same would be true for the dictionary blocks. I'll come up with a way out. Btw, I'm of the opinion of removing deprecated block code especially the ones whose design or implementation have changed significantly ... becomes harder to study code logic. What do you think? |
This is a fresh start to replace #2405
There are four new blocks:
If you use a mouse name as the dictionary name, then you also have access to some internal mouse status, e,g., x, y, heading, pen size, etc.
TODO: