-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: overhaul ignore configs #11938
Conversation
🦋 Changeset detectedLatest commit: 85c15de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@benmccann your suggestions have been applied. What do you think about merging (unifying) the |
I don't have a strong feeling one way or the other. I don't really understand why they're different at the moment |
@@ -1,13 +1,12 @@ | |||
.DS_Store | |||
/package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't this be considered "Output"?
I think if you changed the "Lockfiles" head to "Package managers" then you could put node_modules
there too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't certain about the /packages
directory. When is it used? The package template uses the dist
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we don't need it anymore. it may be leftover. I think svelte-kit package used to output to that location
@benmccann Feel free to make changes directly. I just want a cleanup of ignore files, and would love to reflect maintainers' opinions on this issue. |
@benmccann Appreciate it. Thank you! |
Thank you!! |
This is a recreation of the following issue. Sorry for the inconvenience.
Notable Changes
.eslintignore
- removal of JSON, YAML, and env files from the listNote
JSON and YAML files are not handled by ESLint - plugins have to be installed.
Additional Suggestions
.gitignore
.output
and.vercel
from the default ignore file.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits