Fix Sonarcloud sonar-project.properties #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the emitted sonar.properties file so that header and test files are picked up by Sonarcloud analysis. According to the docs `sonar.tests` is ignored for C/C++ code, so test paths should be treated the same as source paths. Also switches `sonar.inclusions` with `sonar.sources` to fix the include paths being filtered out.
Fixes code coverage builds by switching to using the sonar.inclusions property. Some of our build targets set their source directories in the include paths. Those paths are then emitted in the sonar-project.properties file here. The issue is that this can lead to files being indexed twice which the sonar-scanner treats as an error. Using the `sonar.inclusions` property and adding pattern strings avoids this issue.
|
Kudos, SonarCloud Quality Gate passed!
|
| list(JOIN test_files ",${_sonarcloud_newline}" sonar_tests) | ||
| string(APPEND sonarcloud_project_properties_content "sonar.tests.inclusions=${_sonarcloud_newline}${sonar_tests}\n") | ||
| foreach(source_file ${source_source_files}) | ||
| list(REMOVE_ITEM test_files ${source_file}) |
There was a problem hiding this comment.
What's the purpose of this? There's intersection between these sets of files?
There was a problem hiding this comment.
Yes, e.g.: swiftlets-core library and unit-test-swiftlets-harness test target have threaded_swiftlet.cc source file.
jungleraptor
approved these changes
Aug 26, 2022
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to generate code coverage from the headers which are included only in the test cases.
This PR:
sonar.inclusionspropertysonar.coverage.exclusionsproperty