Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonarcloud sonar-project.properties #127

Merged
merged 11 commits into from
Aug 26, 2022
Merged

Fix Sonarcloud sonar-project.properties #127

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
abd956d
Fix Sonarcloud sonar-project.properties (#120)
jungleraptor Jul 15, 2022
ee54e17
sonarcloud: Use Inclusions Property (#121)
jungleraptor Jul 18, 2022
8e448b2
Exclude test files
krisukox Aug 2, 2022
ec0166e
Check code coverage in libraries created by add_library instead of sw…
krisukox Aug 3, 2022
76ee284
Fix
krisukox Aug 3, 2022
566a737
Exclude test headers
krisukox Aug 3, 2022
a1bc951
Fix
krisukox Aug 4, 2022
1d51435
Fix
krisukox Aug 4, 2022
9edd90f
Fix
krisukox Aug 4, 2022
26377e2
Fix two slashes in directories
krisukox Aug 4, 2022
4131e75
Fix
krisukox Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions Sonarcloud.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,23 @@ function(generate_sonarcloud_project_properties sonarcloud_project_properties_pa

set(sonarcloud_project_properties_content "sonar.sourceEncoding=UTF-8\n")

set(source_files ${source_source_files} ${source_include_directories})
set(source_files ${source_source_files} ${source_include_directories} ${test_source_files})
foreach (dir ${source_include_directories})
if(${dir} MATCHES "/$")
set(source_files ${source_files} ${dir}*.h ${dir}**/*.h)
else()
set(source_files ${source_files} ${dir}/*.h ${dir}/**/*.h)
endif()
endforeach()
list(JOIN source_files ",${_sonarcloud_newline}" sonar_sources)
string(APPEND sonarcloud_project_properties_content "sonar.inclusions=${_sonarcloud_newline}${sonar_sources}\n")

set(test_files ${test_source_files})
list(JOIN test_files ",${_sonarcloud_newline}" sonar_tests)
string(APPEND sonarcloud_project_properties_content "sonar.tests.inclusions=${_sonarcloud_newline}${sonar_tests}\n")
foreach(source_file ${source_source_files})
list(REMOVE_ITEM test_files ${source_file})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this? There's intersection between these sets of files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, e.g.: swiftlets-core library and unit-test-swiftlets-harness test target have threaded_swiftlet.cc source file.

endforeach()
list(JOIN test_files ",${_sonarcloud_newline}" sonar_test_files)
string(APPEND sonarcloud_project_properties_content "sonar.coverage.exclusions=${_sonarcloud_newline}${sonar_test_files}\n")

file(GENERATE
OUTPUT "${sonarcloud_project_properties_path}"
Expand Down