Fixes for test/test_testmon.py (via flake8) #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarpas
reviewed
Jun 27, 2018
| @@ -25,7 +23,7 @@ def test_separation(self, testdir): | |||
| testmon2_data.write_data() | |||
|
|
|||
| testmon_check_data = CoreTestmonData(testdir.tmpdir.strpath, variant='1') | |||
| assert testmon1_data.node_data['node1'] == {'a.py': 1} | |||
There was a problem hiding this comment.
testmon_check_data is unused here - should just the assignment get skipped?
(I've assumed that the assert should be for testmon_check_data)
There was a problem hiding this comment.
@tarpas
Please verify that this is sane, and I will rebase this.
There was a problem hiding this comment.
I guess this test should check if data is not overwritten when different variant is used. But the data is never written to DB since condition in write_data() in not met. Also testmon_check_data.read_data() is never called. So i am not really sure.
tarpas
reviewed
Jun 27, 2018
blueyed
commented
Jun 27, 2018
|
@tarpas |
tarpas
force-pushed
the
master
branch
2 times, most recently
from
fd8d9cb to
c369e8c
Compare
|
Sorry, this is not relevant any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about
test_separation, but at least it needs to be adjusted in some way.