WIP: skip pytest_ignore_collect with -k/-m #136
Conversation
| @@ -150,6 +150,10 @@ def __init__(self, config, testmon_data): | |||
| self.f_to_ignore = self.testmon_data.stable_files | |||
| if self.config.getoption('tlf'): | |||
| self.f_to_ignore -= self.testmon_data.f_last_failed | |||
| self.has_possibly_filtering_args = any( | |||
| x for x in config._origargs | |||
There was a problem hiding this comment.
Not a public attribute: pytest-dev/pytest#5106
There was a problem hiding this comment.
how about has_k_m_args , or has_filtering_args?
There was a problem hiding this comment.
has_filtering_args would be ok, but it is not given that they actually filter anythings - that's why I had the longer name I guess.
|
I think think this would be a change for the better. I quite dislike the name has_possibly_filtering_args :) |
| @@ -150,6 +150,10 @@ def __init__(self, config, testmon_data): | |||
| self.f_to_ignore = self.testmon_data.stable_files | |||
| if self.config.getoption('tlf'): | |||
| self.f_to_ignore -= self.testmon_data.f_last_failed | |||
| self.has_possibly_filtering_args = any( | |||
| x for x in config._origargs | |||
There was a problem hiding this comment.
how about has_k_m_args , or has_filtering_args?
|
Not anytime soon. I also think that other PRs are more important first. |
tarpas
force-pushed
the
master
branch
2 times, most recently
from
fd8d9cb to
c369e8c
Compare
|
Thanks, this class of reports inspired me to rewrite testmon, so this is hopefully not relevant any more. |
Ref: #135