Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: tkn pipeline version #463

Closed
praveen4g0 opened this issue Nov 14, 2019 · 7 comments · Fixed by #703
Closed

Feature Request: tkn pipeline version #463

praveen4g0 opened this issue Nov 14, 2019 · 7 comments · Fixed by #703
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@praveen4g0
Copy link

praveen4g0 commented Nov 14, 2019

Expected Behavior

tkn pipeline version
pipeline version : v0.8.0
or
tkn version
Client version: 0.5.0
Server version: 0.8.0

Actual Behavior

N/A
or
tkn version
Client version: 0.5.0

Additional Info

@piyush-garg
Copy link
Contributor

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 14, 2019
@vdemeester
Copy link
Member

@praveen4g0 This is a tricky one, but two points

Also, kn is going to return the api version instead of the "knative release version". I think it might make more sense as it is what make the contract. But this is open to questions 👼 😉

@danielhelfand
Copy link
Member

Dupe of #159. I'll close #159 though since a lot of the conversation is happening here.

@waveywaves
Copy link
Member

/assign

@chmouel
Copy link
Member

chmouel commented Nov 29, 2019

@waveywaves that one is a tricky one fyi, which involves some hard to tackle change in pipeline (to answer the question "what is the pipeline version" question)

@waveywaves
Copy link
Member

Yes I was just checking that out. I was thinking something along the lines of https://github.com/kubernetes/kubernetes/tree/7f23a743e8c23ac6489340bbb34fa6f1d392db9d/staging/src/k8s.io/client-go/pkg/version in tektoncd/pipeline

@chmouel
Copy link
Member

chmouel commented Feb 11, 2020

/assign

chmouel added a commit to chmouel/tektoncd-cli that referenced this issue Feb 11, 2020
Add pipeline service version information to `tkn pipeline version`. The logic
has been imported from dashboard https://git.io/JvC4h

I don't have a full test for it, since the machinery to fake a Deployment is
quite tedious to import/implement and this is not used anywhere else.

Closes tektoncd#463

Signed-off-by: Chmouel Boudjnah <[email protected]>
tekton-robot pushed a commit that referenced this issue Feb 12, 2020
Add pipeline service version information to `tkn pipeline version`. The logic
has been imported from dashboard https://git.io/JvC4h

I don't have a full test for it, since the machinery to fake a Deployment is
quite tedious to import/implement and this is not used anywhere else.

Closes #463

Signed-off-by: Chmouel Boudjnah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
7 participants