tkn version reflects pipeline version

[waveywaves]

fixes #463

Changes

• This PR will have to wait for being merged till the next release for pipline happens I suppose.
• fixes Feature Request: tkn pipeline version #463

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Regenerate the manpages and docs with make docs and make man if needed.
• Run the code checkers with make check
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign danielhelfand
You can assign the PR to them by writing /assign @danielhelfand in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

Hi @waveywaves. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[piyush-garg]

/ok-to-test
/hold

[tekton-robot]

@waveywaves: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-tekton-cli-build-cross-tests	3fd3feb	link	/test pull-tekton-cli-build-cross-tests
pull-tekton-cli-unit-tests	3fd3feb	link	/test pull-tekton-cli-unit-tests
pull-tekton-cli-integration-tests	3fd3feb	link	/test pull-tekton-cli-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[chmouel]

It's a bit misleading , this refer to the library dependency version not the running pipeline version , interesting for tkn cli devs but not really for our users (and mislead the user)

[vdemeester]

As @chmouel said, it's gonna be misleading and will always be -dev as this is using it as library. To get the version from the server, we need to query it 👼

[waveywaves]

@vdemeester @chmouel Yeah that makes sense. It would make more sense to have the version to be exposed via the API or on a label in a namespace becuase it will pick up dev :/ I will try that out instead.

[chmouel]

maybe i am wrong but i don't think there is a way to do with CRDs?

[vdemeester]

maybe i am wrong but i don't think there is a way to do with CRDs?

So far, nope 😓

[hrishin]

@waveywaves @chmouel @vdemeester how about adding one more end point in pipelines /version, just like it has /metrics end point?

[vdemeester]

@waveywaves @chmouel @vdemeester how about adding one more end point in pipelines /version, just like it has /metrics end point?

It could work indeed 👼 might required some changes in knative/pkg 👼

[chmouel]

Are you updating this @waveywaves ?

[waveywaves]

@chmouel Yes I will be updating it right away !