Update ClusterTask Tests from Test Builders to Structs #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XL
danielhelfand
commented
Sep 15, 2020
Comment on lines
-516
to
-530
| { | ||
| name: "Dry run with no output v1beta1", | ||
| command: []string{"start", "clustertask-2", | ||
| "-i", "my-repo=git", | ||
| "-o", "code-image=output-image", | ||
| "-l", "key=value", | ||
| "-s=svc1", | ||
| "--dry-run", | ||
| }, | ||
| dynamic: seeds[4].dynamicClient, | ||
| input: seeds[4].pipelineClient, | ||
| inputStream: nil, | ||
| wantError: false, | ||
| goldenFile: true, | ||
| }, |
There was a problem hiding this comment.
Not sure what this test was intended for. The name suggests it's a v1beta1 test, but it's part of the v1alpha1 suite.
danielhelfand
commented
Sep 15, 2020
| @@ -1,23 +0,0 @@ | |||
| apiVersion: tekton.dev/v1beta1 | |||
There was a problem hiding this comment.
This golden file appears to be unused.
vdemeester
approved these changes
Sep 16, 2020
tekton-robot
added
the
approved
piyush-garg
requested changes
Sep 16, 2020
...estdata/Test_ClusterTask_Start-Dry_Run_with_--use-param-defaults_and_specified_params.golden
Outdated
Show resolved
Hide resolved
piyush-garg
reviewed
Sep 16, 2020
...Test_ClusterTask_Start_v1beta1-Dry_Run_with_--use-param-defaults_and_specified_params.golden
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
danielhelfand
added a commit
that referenced
this pull request
Sep 30, 2020
#1167 | [Daniel Helfand] update condition tests from test builders to structs | 2020/09/16-11:10 #1154 | [vinamra28] Enable auto-select support in ClusterTaskDescribe if only one is present | 2020/09/16-17:00 #1154 | [vinamra28] Enable auto-select support in TaskRunDescribe if only one is present | 2020/09/16-17:00 #1173 | [Daniel Helfand] update README versions for v0.12.1 | 2020/09/16-17:21 #1176 | [Bart] Artwork/Logo added to the top of the README. | 2020/09/16-18:14 #1172 | [Chmouel Boudjnah] Fix rpm build for release | 2020/09/17-14:34 #1168 | [Daniel Helfand] update clustertask tests from test builders to structs | 2020/09/18-13:26 #1177 | [Vincent Demeester] tests: import pipeline internal builders 🏒 | 2020/09/18-17:31 #1179 | [vinamra28] Use --prefix-name option for tkn clustertask start | 2020/09/18-23:07 #1182 | [Daniel Helfand] update pipelineresource tests from test builders to structs | 2020/09/21-14:29 null | [Vincent Demeester] Remove release-note block indentation in PR template 🌮 | 2020/09/22-11:57 null | [savitaashture] Modify tkn version to accept ldflag and namespace flag | 2020/09/24-10:14 null | [savitaashture] Fix deployment fetch issue for multiple namespaces | 2020/09/25-11:54 null | [PuneetPunamiya] This patch fixes: | 2020/09/28-19:27 null | [Divyansh42] Modify tkn version output to hide Triggers and Dashboard version if they are not installed and added required unit tests. | 2020/09/29-04:57 null | [Piyush Garg] Bump pipeline and triggers dep | 2020/09/29-13:55 null | [Divyansh42] Enable auto-select support in pipelineDescribe if only one pipeline is present | 2020/09/29-17:29 null | [vinamra28] Add --use-taskrun for ClusterTask start | 2020/09/30-11:08 null | [Divyansh42] Enable auto select support in PipelineRunDescribe if only one PipelineRun is present | 2020/09/30-13:13 Signed-off-by: Daniel Helfand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1145
Migrating unit tests for
tkn clustertaskfrom test builders to structs.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedRelease Notes