Move from pipeline builders to structs

[piyush-garg]

Right now, in CLI unit tests and probably e2e test also, pipeline builders are getting used to create test data. Pipeline builders have been marked deprecated and now with the merge of PR tektoncd/pipeline#3124 they will get removed.

As it happens and we bump the pipeline dependency in CLI to that pipeline version, it may break all our tests. Possible solutions to go forward is

• Modify all the tests to use structs rather than the builders.
• Copy the builders(which are in internal pkg) to CLI codebase from vendor and use (Maybe a workaround )

Creating this issue so that we can keep track and do the needful.

[danielhelfand]

Should we break this down into sub tasks by command and keep a check list?

[piyush-garg]

Let's keep a checklist

• Conditions - @danielhelfand (Update Condition Tests from Test Builders to Structs #1167)
• ClusterTask - @danielhelfand (Update ClusterTask Tests from Test Builders to Structs #1168)
• Pipeline - @pratap0007 (Replace test builders to structs in unit test for tkn pipeline #1457)
• PipelineRun - @pratap0007 (Replace test builders to structs in unit test for tkn pipelinerun #1463)
• Task - @vinamra28 (Update Task Tests from Test Builders to Structs #1289)
• TaskRun - @vinamra28 (Update TaskRun Tests from Test Builders to Structs #1292)
• Resource - @danielhelfand (Update PipelineResource Tests from Test Builders to Structs #1182)

[danielhelfand]

I am wondering if the proper approach for this issue would be to eventually only support one version of the Tekton API (v1beta1) and remove v1alpha1 tests all together. We would obviously not be able to do this immediately and should give warning to users. There would also need to be some research in to how well v1beta1 tests are aligned with v1alpha1 testing.

[vdemeester]

/reopen
Didn't meant to close it in #1177 😅

[tekton-robot]

@vdemeester: Reopened this issue.

In response to this:

/reopen
Didn't meant to close it in #1177 😅

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vinamra28]

Let's keep a checklist

• Conditions - @danielhelfand (Update Condition Tests from Test Builders to Structs #1167)
• ClusterTask - @danielhelfand (Update ClusterTask Tests from Test Builders to Structs #1168)
• Pipeline - @pratap0007 (Replace test builders to structs in unit test for tkn pipeline #1457)
• PipelineRun - @pratap0007 (Replace test builders to structs in unit test for tkn pipelinerun #1463)
• Task - @vinamra28 (Update Task Tests from Test Builders to Structs #1289)
• TaskRun - @vinamra28 (Update TaskRun Tests from Test Builders to Structs #1292)
• Resource - @danielhelfand (Update PipelineResource Tests from Test Builders to Structs #1182)

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[vinamra28]

/remove-lifecycle rotten

[piyush-garg]

• Cleanup PR - @piyush-garg Remove builders from codebase #1466