Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Task Tests from Test Builders to Structs #1289

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Update Task Tests from Test Builders to Structs #1289

merged 1 commit into from
Feb 4, 2021

Conversation

vinamra28
Copy link
Member

@vinamra28 vinamra28 commented Jan 22, 2021 •
edited
Loading

Changes

Migrating unit tests for tkn task from test builders to structs.

Part of #1145

Signed-off-by: vinamra28 [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

@vinamra28
Update Task Tests from Test Builders to Structs
54aa8e8 
Migrating unit tests for `tkn task` from test builders to structs.

Signed-off-by: vinamra28 <[email protected]>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 22, 2021
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 22, 2021
@vinamra28
Copy link
Member Author

/cc @pradeepitm12 @piyush-garg @chmouel

pradeepitm12
pradeepitm12 reviewed Feb 2, 2021
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2021
@chmouel
Copy link
Member

chmouel commented Feb 2, 2021

/lgtm
/approve

🚀

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2021
@piyush-garg
Copy link
Contributor

/lgtm
/approve
/retest

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chmouel,piyush-garg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member

/retest

2 similar comments
@vinamra28
Copy link
Member Author

/retest

@vinamra28
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit 450bf77 into tektoncd:master Feb 4, 2021
@vinamra28 vinamra28 deleted the vinamra28/test-builder-to-structs branch February 4, 2021 15:33
@vinamra28 vinamra28 mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradeepitm12 pradeepitm12 pradeepitm12 left review comments

@hrishin hrishin Awaiting requested review from hrishin

@vdemeester vdemeester Awaiting requested review from vdemeester

@chmouel chmouel Awaiting requested review from chmouel

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@chmouel chmouel

@piyush-garg piyush-garg

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vinamra28 @chmouel @piyush-garg @tekton-robot @vdemeester @pradeepitm12