Add a pipeline export command #1398

chmouel · 2021-06-19T17:10:58Z

Will export the pipeline definition to a yaml file, removing the auto generated
fields.

If you do a tkn pipeline export pipeline it will convert a pipeline that look like this :

https://paste.gg/p/anonymous/e105629cffe547238f125f0862aa23be

and export it like that :

https://paste.gg/p/anonymous/7515299fddbe44b3b54aaf12e6a7bba1

Partially address bug #1220

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Run the code checkers with make check
Regenerate the manpages, docs and go formatting with make generated
Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

tekton-robot · 2021-06-19T17:13:20Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/export.go	Do not exist	17.9%

chmouel · 2021-06-19T17:14:20Z

Probably should discuss this next cli WG

I am torn between :

tkn export pipeline

or like this is implemented here :

tkn pipeline export

Or calling it convert instead of export

cc @nikhil-thomas @siamaksade @tektoncd/cli-maintainers

tekton-robot · 2021-06-19T17:27:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/export.go	Do not exist	17.9%

chmouel · 2021-06-21T06:46:54Z

OOps just saw there is @vinamra28 #1359 (comment) which is not the same but pretty similiar, either way I can update this PR post 1359 or close this if 1359 addresse this use case (exporting a task as yaml)

chmouel · 2021-06-23T10:11:03Z

/retest

vinamra28

can we have a unit test for this command as well in order to maintain the consistency?

pkg/cmd/pipeline/export.go

chmouel · 2021-06-23T11:41:07Z

Yup will work on this (when i get some time :))

tekton-robot · 2021-10-15T13:58:33Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot · 2021-11-14T14:11:33Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot · 2021-12-14T15:05:36Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot · 2021-12-14T15:05:38Z

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2021-12-17T07:29:55Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/export.go	Do not exist	17.9%

vinamra28 · 2021-12-17T08:02:28Z

/remove-lifecycle rotten

chmouel · 2022-01-06T11:53:44Z

/hold cancel

tekton-robot · 2022-01-06T11:56:09Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/export.go	Do not exist	17.9%
pkg/export/export.go	Do not exist	100.0%

tekton-robot · 2022-01-14T07:30:07Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/export.go	Do not exist	16.1%
pkg/export/export.go	Do not exist	100.0%

pkg/cmd/pipeline/export.go

Will export the pipeline definition to a yaml file, removing the auto generated fields. Partially address bug tektoncd#1220 Signed-off-by: Chmouel Boudjnah <[email protected]>

chmouel · 2022-01-14T12:00:22Z

Thanks @vinamra28 there was a lot of warnings when running locally with newer golangci-lint (cf: #1481) and didn't see this one

tekton-robot · 2022-01-14T12:02:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/export.go	Do not exist	16.1%
pkg/export/export.go	Do not exist	100.0%

vinamra28

/lgtm
/meow

tekton-robot · 2022-01-14T12:14:28Z

@vinamra28:

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pradeepitm12 · 2022-01-21T09:26:24Z

pkg/export/export.go

+// like creationTimeStamp since it's a time.Time that is not a pointer yaml would display a creationTimeStamp: null
+// let's do some regexp magic here, which should hopefully safe.
+func pipelineExportRemoveExtraFields(input string) string {
+	m1 := regexp.MustCompile(`\n  creationTimestamp: null\n`)


\n creationTimestamp: null\n
Do we need two spaces in the regex

Yep that's how it matches ,what do you suggest we do ? Having a \s* ?

My editor showed an error for this 😸 just wanted to check.
/lgtm

tekton-robot · 2022-01-21T09:42:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradeepitm12, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pradeepitm12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 Signed-off-by: Pradeep Kumar <[email protected]>

#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 Signed-off-by: Pradeep Kumar <[email protected]>

#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 Signed-off-by: Pradeep Kumar <[email protected]>

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 19, 2021

tekton-robot requested review from danielhelfand and piyush-garg June 19, 2021 17:11

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 19, 2021

chmouel force-pushed the issue-1220-provide-a-tkn-command-to-export-a-pipeline-without-k branch from 5dca927 to 6a98a9b Compare June 19, 2021 17:24

vinamra28 reviewed Jun 23, 2021

View reviewed changes

pkg/cmd/pipeline/export.go Outdated Show resolved Hide resolved

pkg/cmd/pipeline/export.go Show resolved Hide resolved

tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2021

tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 14, 2021

tekton-robot closed this Dec 14, 2021

chmouel reopened this Dec 17, 2021

tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 17, 2021

chmouel force-pushed the issue-1220-provide-a-tkn-command-to-export-a-pipeline-without-k branch from 6a98a9b to 8ea0dd9 Compare January 6, 2022 11:53

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2022

chmouel force-pushed the issue-1220-provide-a-tkn-command-to-export-a-pipeline-without-k branch from 8ea0dd9 to 6a672e3 Compare January 6, 2022 11:57

chmouel force-pushed the issue-1220-provide-a-tkn-command-to-export-a-pipeline-without-k branch from ccd24f7 to dd51136 Compare January 14, 2022 07:26

vinamra28 reviewed Jan 14, 2022

View reviewed changes

pkg/cmd/pipeline/export.go Outdated Show resolved Hide resolved

Add a pipeline export command

1f719b3

Will export the pipeline definition to a yaml file, removing the auto generated fields. Partially address bug tektoncd#1220 Signed-off-by: Chmouel Boudjnah <[email protected]>

chmouel force-pushed the issue-1220-provide-a-tkn-command-to-export-a-pipeline-without-k branch from dd51136 to 1f719b3 Compare January 14, 2022 11:59

vinamra28 approved these changes Jan 14, 2022

View reviewed changes

tekton-robot assigned vinamra28 Jan 14, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022

pradeepitm12 reviewed Jan 21, 2022

View reviewed changes

tekton-robot assigned pradeepitm12 Jan 21, 2022

pradeepitm12 approved these changes Jan 21, 2022

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022

tekton-robot merged commit 32e3d7e into tektoncd:main Jan 21, 2022

chmouel deleted the issue-1220-provide-a-tkn-command-to-export-a-pipeline-without-k branch January 21, 2022 09:48

xinnjie mentioned this pull request Jul 19, 2023

Provide a tkn command to export a pipeline without K8s metadata to be used for version control #1220

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a pipeline export command #1398

Add a pipeline export command #1398

chmouel commented Jun 19, 2021 •

edited

Loading

tekton-robot commented Jun 19, 2021

chmouel commented Jun 19, 2021 •

edited

Loading

tekton-robot commented Jun 19, 2021

chmouel commented Jun 21, 2021

chmouel commented Jun 23, 2021

vinamra28 left a comment

chmouel commented Jun 23, 2021 •

edited

Loading

tekton-robot commented Oct 15, 2021

tekton-robot commented Nov 14, 2021

tekton-robot commented Dec 14, 2021

tekton-robot commented Dec 14, 2021

tekton-robot commented Dec 17, 2021

vinamra28 commented Dec 17, 2021

chmouel commented Jan 6, 2022

tekton-robot commented Jan 6, 2022

tekton-robot commented Jan 14, 2022

chmouel commented Jan 14, 2022

tekton-robot commented Jan 14, 2022

vinamra28 left a comment

tekton-robot commented Jan 14, 2022

pradeepitm12 Jan 21, 2022

chmouel Jan 21, 2022

pradeepitm12 Jan 21, 2022

tekton-robot commented Jan 21, 2022

Add a pipeline export command #1398

Add a pipeline export command #1398

Conversation

chmouel commented Jun 19, 2021 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Jun 19, 2021

chmouel commented Jun 19, 2021 • edited Loading

tekton-robot commented Jun 19, 2021

chmouel commented Jun 21, 2021

chmouel commented Jun 23, 2021

vinamra28 left a comment

Choose a reason for hiding this comment

chmouel commented Jun 23, 2021 • edited Loading

tekton-robot commented Oct 15, 2021

tekton-robot commented Nov 14, 2021

tekton-robot commented Dec 14, 2021

tekton-robot commented Dec 14, 2021

tekton-robot commented Dec 17, 2021

vinamra28 commented Dec 17, 2021

chmouel commented Jan 6, 2022

tekton-robot commented Jan 6, 2022

tekton-robot commented Jan 14, 2022

chmouel commented Jan 14, 2022

tekton-robot commented Jan 14, 2022

vinamra28 left a comment

Choose a reason for hiding this comment

tekton-robot commented Jan 14, 2022

pradeepitm12 Jan 21, 2022

Choose a reason for hiding this comment

chmouel Jan 21, 2022

Choose a reason for hiding this comment

pradeepitm12 Jan 21, 2022

Choose a reason for hiding this comment

tekton-robot commented Jan 21, 2022

chmouel commented Jun 19, 2021 •

edited

Loading

chmouel commented Jun 19, 2021 •

edited

Loading

chmouel commented Jun 23, 2021 •

edited

Loading