-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace test builders to structs in unit test for tkn pipeline
#1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
label
Oct 1, 2021
tekton-robot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Oct 1, 2021
vdemeester
approved these changes
Oct 4, 2021
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 4, 2021
/retest |
pratap0007
force-pushed
the
test-builder-to-struct
branch
from
October 8, 2021 04:04
fe57c1d
to
8789418
Compare
/test pull-tekton-cli-build-tests |
Signed-off-by: Shiv Verma <[email protected]>
pratap0007
force-pushed
the
test-builder-to-struct
branch
from
October 8, 2021 07:48
8789418
to
560283e
Compare
/lgtm |
pradeepitm12
added a commit
that referenced
this pull request
Jan 31, 2022
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12
added a commit
that referenced
this pull request
Jan 31, 2022
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12
added a commit
that referenced
this pull request
Jan 31, 2022
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12
added a commit
that referenced
this pull request
Jan 31, 2022
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12
added a commit
that referenced
this pull request
Jan 31, 2022
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12
added a commit
that referenced
this pull request
Feb 1, 2022
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12
added a commit
that referenced
this pull request
Feb 1, 2022
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12
added a commit
that referenced
this pull request
Feb 1, 2022
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 null | [Pradeep Kumar] update goreleaser | 2022/02/01-09:36 Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12
added a commit
that referenced
this pull request
Feb 1, 2022
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 null | [Pradeep Kumar] update goreleaser | 2022/02/01-09:36 null | [Pradeep Kumar] update goreleaser config | 2022/02/01-11:28 Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12
added a commit
that referenced
this pull request
Feb 1, 2022
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 null | [Pradeep Kumar] update goreleaser | 2022/02/01-09:36 null | [Pradeep Kumar] update goreleaser config | 2022/02/01-11:28 Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12
added a commit
that referenced
this pull request
Feb 1, 2022
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 null | [Pradeep Kumar] update goreleaser | 2022/02/01-09:36 null | [Pradeep Kumar] update goreleaser config | 2022/02/01-11:28 Signed-off-by: Pradeep Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
lgtm
Indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replace test builders to structs in unit test for
tkn pipeline
Part of #1145
Signed-off-by: Shiv Verma [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.
Release Notes