Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task's step(s) showing as success even if they are not #56

Closed
vdemeester opened this issue Apr 16, 2019 · 4 comments
Closed

Task's step(s) showing as success even if they are not #56

vdemeester opened this issue Apr 16, 2019 · 4 comments
Assignees

Comments

@vdemeester
Copy link
Member

If a step fails (using tektoncd/pipeline@master), dashboard might report it as success even though it is not (hence the task status and the pipeline status in the following screenshot)

2019-04-16-191519

Looking at the status, it didn't look at the correct status for the step (the step exited with 1, but the status reported 1)

The screenshot is taken on a run based on the following files : https://sbr.pm/technical/tekton-usage.html#org63ddf32

/kind bug

@AlanGreene
Copy link
Member

/assign

@tekton-robot
Copy link
Contributor

@AlanGreene: GitHub didn't allow me to assign the following users: AlanGreene.

Note that only tektoncd members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

Now that step name is included in task run status (tektoncd/pipeline#657) it should be much easier to reliably match the step / status without relying on order and trying to account for init containers.

/assign

@AlanGreene
Copy link
Member

@vdemeester issue should be resolved now, let me know if you still get any unexpected step status.

barthy1 pushed a commit to barthy1/dashboard that referenced this issue Apr 14, 2021
It looked like the indentation was off, and also some of the environment
variables (e.g. $PULL_REF) provided to presubmit jobs aren't provided
to presubmit jobs. I tried to copy example configuration in the
kubernetes test-infra repo but the prow "initupload" container is still
failing with an error about cloning refs.

(continuation of tektoncd#56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants