Use newly added name field in step status to find correct results #95
Conversation
Instead of attempting to match step status in task runs by index, accounting for presence / order of init containers, use the newly added name field in the step status so we can reliably link steps to their status and logs regardless of order. This involves updating Gopkg.lock to use github.com/tektoncd/pipeline revision 3415c18f7728476c132f692d9a55a70b7b194c5d which introduced the new field.
tekton-robot
added
approved
|
/hold |
tekton-robot
added
the
do-not-merge/hold
|
/assign @a-roberts |
|
So we're not breaking anything on 0.2 and we're benefitting from a new change that went into master about a week ago and thus the 0.3 release right @AlanGreene? |
|
That's right, everything else appears to be working as expected. |
|
Sounds good to me then, thanks /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-roberts, AlanGreene, steveodonovan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
#56
Instead of attempting to match step status in task runs by index,
accounting for presence / order of init containers, use the
newly added name field in the step status so we can reliably
link steps to their status and logs regardless of order.
This involves updating Gopkg.lock to use github.com/tektoncd/pipeline
revision 3415c18f7728476c132f692d9a55a70b7b194c5d which introduced
the new field.