Refactors TektonPipeline Reconciler #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XXL
|
/hold |
tekton-robot
added
the
do-not-merge/hold
|
The following is the coverage report on the affected files.
|
tekton-robot
added
the
needs-rebase
|
The refacotring is great. Now the reconciler is more Readable 👍 |
sm43
force-pushed
the
refactor-pipelines
branch
from
f261e40 to
811229d
Compare
tekton-robot
removed
the
needs-rebase
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
|
The following is the coverage report on the affected files.
|
sm43
commented
Sep 2, 2021
sm43
force-pushed
the
refactor-pipelines
branch
from
811229d to
c3c7d1e
Compare
|
The following is the coverage report on the affected files.
|
sm43
force-pushed
the
refactor-pipelines
branch
from
c3c7d1e to
d8757e8
Compare
|
The following is the coverage report on the affected files.
|
sm43
force-pushed
the
refactor-pipelines
branch
from
d8757e8 to
6f76b77
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
sm43
force-pushed
the
refactor-pipelines
branch
from
de79b56 to
ab0dc03
Compare
|
The following is the coverage report on the affected files.
|
|
/retest |
sm43
force-pushed
the
refactor-pipelines
branch
from
ab0dc03 to
a25cbea
Compare
|
The following is the coverage report on the affected files.
|
This was referenced Sep 6, 2021
tekton-robot
added
the
needs-rebase
sm43
force-pushed
the
refactor-pipelines
branch
from
a25cbea to
cd69d3e
Compare
tekton-robot
removed
the
needs-rebase
|
The following is the coverage report on the affected files.
|
added 4 commits
September 6, 2021 17:58
This adds TektonInstaller which would install the manifest passed in spec in a certain order defined, TektonPipeline/TektonTrigger and other components will transform their manifest and pass to TektonInstallerSet which will create the resources. The components will create an tekton installer set and pass the manifest. - while upgrading the version components can delete prev installer set and create new one which will delete any obsolete resource removed in ' newer version. - to change namespace of installed components, create a new installer set and delete prev. Deleting a installer will delete all resources except crds which would not delete any user data. Signed-off-by: Shivam Mukhade <[email protected]>
This updates the reconciler to use TektonInstallerSet to install the pipelines component. If version is changed or target namespace is changed then previous TektonInstallerSet will get deleted and a new one will be created with required spec. Signed-off-by: Shivam Mukhade <[email protected]>
As we have changed the installation flow for TektonPipelines some of the test are failing as they use to run with TektonPipeline so till we refactor all components changing them to run on TektonTriggers as we refactor those will be updated. Signed-off-by: Shivam Mukhade <[email protected]>
This enable the installer set for openshift and in extension update the code to install resources directly instead of using common pkg which has prev install flow, which would break now as older condtions are used in common/install which are now removed for TektonPipeline. Signed-off-by: Shivam Mukhade <[email protected]>
sm43
force-pushed
the
refactor-pipelines
branch
from
cd69d3e to
82bd3b5
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shivam Mukhade [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes