[OpenShift] Add param to enable/disable servicemonitor #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
needs-rebase
sm43
force-pushed
the
service-monitor
branch
from
1226ce4 to
a0a6c6e
Compare
tekton-robot
removed
the
needs-rebase
sm43
force-pushed
the
service-monitor
branch
from
a0a6c6e to
27d571d
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
vdemeester
approved these changes
Sep 6, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/hold |
tekton-robot
added
the
do-not-merge/hold
sm43
force-pushed
the
service-monitor
branch
from
27d571d to
9d09dcc
Compare
|
The following is the coverage report on the affected files.
|
sm43
force-pushed
the
service-monitor
branch
from
9d09dcc to
1307f0d
Compare
|
The following is the coverage report on the affected files.
|
sm43
force-pushed
the
service-monitor
branch
from
1307f0d to
605c9db
Compare
|
The following is the coverage report on the affected files.
|
tekton-robot
added
the
needs-rebase
added 2 commits
September 13, 2021 12:01
Before webhook we had default value for pruner's keep as 1 but we expect user to define all values now so if a user has installed prev version and has not enabled pruner then `keep` will have a value 1 and after upgrading to newer version, webhook will fail if keep has a value and other fields are not defined this handles that case by removing the default for keep if other pruner fields are not defined Signed-off-by: Shivam Mukhade <[email protected]>
This adds a param in TektonConfig & TektonPipeline to disable service monitor which is a part of TektonPipelines for OpenShift. Param will be added by default, user can change the value in TektonConfig to false to disable. Value is added in openshift extension and not in webhook as this is platform specific param. If invalid value is passed then default value is set for param to avoid installation failure. Users can pass valid values and change the param. Signed-off-by: Shivam Mukhade <[email protected]>
sm43
force-pushed
the
service-monitor
branch
from
605c9db to
f1b3a7d
Compare
tekton-robot
removed
the
needs-rebase
|
The following is the coverage report on the affected files.
|
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a param in TektonConfig & TektonPipeline to disable service monitor
which is a part of TektonPipelines for OpenShift.
Param will be added by default, user can change the value in TektonConfig
to false to disable.
Value is added in openshift extension and not in webhook as this is
platform specific param.
If invalid value is passed then default value is set for param to avoid
installation failure. Users can pass valid values and change the param.
Signed-off-by: Shivam Mukhade [email protected]
Also,
Handle upgrade from older version which has pruner defaults
Before webhook we had default value for pruner's keep as 1
but we expect user to define all values now so if a user has
installed prev version and has not enabled pruner then
keepwill have a value 1 and after upgrading to newer version,
webhook will fail if keep has a value and other fields are not defined
this handles that case by removing the default for keep if
other pruner fields are not defined
Signed-off-by: Shivam Mukhade [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes