Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Operator for Results v0.3.1 #495

Merged
merged 1 commit into from
Nov 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ KO = $(or ${KO_BIN},${KO_BIN},$(BIN)/ko)
PIPELINES_VERSION ?= latest
TRIGGERS_VERSION ?= latest
DASHBOARD_VERSION ?= latest
RESULTS_VERSION ?= latest
RESULTS_VERSION ?= v0.3.1 # latest returns an older version hence hard coding to v0.3.1 for now (tektoncd/results#138)

$(BIN)/ko: PACKAGE=github.com/google/ko/cmd/ko

Expand Down
4 changes: 2 additions & 2 deletions docs/TektonResult.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ To install Tekton Result on your cluster follow steps as given below:
the following properties:

- namespace: `tekton-pipelines`
- name: `tekton-results-mysql`
- name: `tekton-results-postgres`
- contains the fields:
- `user=root`
- `password=<your password>`
Expand All @@ -30,7 +30,7 @@ To install Tekton Result on your cluster follow steps as given below:
Update namespace value in the command if Tekton Pipelines is installed in a different namespace..

```sh
$ kubectl create secret generic tekton-results-mysql --namespace=tekton-pipelines --from-literal=user=root --from-literal=password=$(openssl rand -base64 20)
$ kubectl create secret generic tekton-results-postgres --namespace="tekton-pipelines" --from-literal=POSTGRES_USER=postgres --from-literal=POSTGRES_PASSWORD=$(openssl rand -base64 20)
```
- Generate cert/key pair.
Note: Feel free to use any cert management software to do this!
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/kubernetes/tektonresult/tektonresult.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import (
)

const (
DbSecretName = "tekton-results-mysql"
DbSecretName = "tekton-results-postgres"
TlsSecretName = "tekton-results-tls"
)

Expand Down
2 changes: 1 addition & 1 deletion test/config.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export PIPELINES_VERSION=latest
export TRIGGERS_VERSION=latest
export RESULTS_VERSION=latest
export RESULTS_VERSION=v0.3.1
export DASHBOARD_VERSION=latest
4 changes: 2 additions & 2 deletions test/e2e/kubernetes/tektonresultdeployment_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ func createSecret(t *testing.T, clients *utils.Clients, namespace string) {
Name: tektonresult.DbSecretName,
},
Data: map[string][]byte{
"user": []byte("root"),
"password": []byte("test"),
"POSTGRES_USER": []byte("postgres"),
"POSTGRES_PASSWORD": []byte("test"),
},
}

Expand Down