-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Operator for Results v0.3.1 #495
Conversation
/approve |
/hold |
In v0.3.1, the db secret name is changed as Results API now uses a Postgres implementation instead of MySQL. Also, updates the CI to fetch 0.3.1 for testing instead of latest because of a bug tektoncd/results#138 Signed-off-by: Shivam Mukhade <[email protected]>
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In v0.3.1, the db secret name is changed as Results API now uses a
Postgres implementation instead of MySQL.
Also, updates the CI to fetch 0.3.1 for testing instead of latest because
of a bug tektoncd/results#138
Signed-off-by: Shivam Mukhade [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes
For pull requests that don't need to be mentioned at release time, use the
/release-note-none
Prow command to add therelease-note-none
label to the PR. You can also write the string "NONE" as a release note in your PR description: