Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default TaskRun timeout is too short. #979

Closed
abayer opened this issue Jun 12, 2019 · 7 comments · Fixed by #996
Closed

The default TaskRun timeout is too short. #979

abayer opened this issue Jun 12, 2019 · 7 comments · Fixed by #996
Assignees
@houshengbo
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@abayer
Copy link
Contributor

abayer commented Jun 12, 2019

Expected Behavior

A user shouldn't have their TaskRuns killed in 10 minutes if they haven't specified a larger PipelineRun timeout.

Actual Behavior

The TaskRuns do get killed.

Steps to Reproduce the Problem

  1. Kinda obvious, really. =)

Additional Info

We should bump this up to something more reasonable. Also relates to #978.
@carlossg carlossg mentioned this issue Jun 12, 2019
Closed
3 tasks
@vdemeester vdemeester added kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 12, 2019
@vdemeester
Copy link
Member

@abayer I feel there is two things we could do :

  • Bump the timeout to something more reasonable (as a default), like 25min or sthg
  • Make it possible to configure the default Pipeline timeout on the controller side

@abayer
Copy link
Contributor Author

abayer commented Jun 12, 2019

@vdemeester The latter would be fantastic.

abayer added a commit to abayer/jx that referenced this issue Jun 12, 2019
@abayer
fix(tekton): Set a default PipelineRun timeout of 10 days
d6d194e 
Starting in Tekton Pipelines v0.4.0, the default timeout for
`TaskRun`s of 10 minutes when no timeout is specified is actually
enforced. The only way to specify a timeout for a `TaskRun` is by
setting a timeout on the `PipelineRun`, so until
tektoncd/pipeline#978 and/or
tektoncd/pipeline#979 are addressed, we
should just set a ridiculously high timeout on all `PipelineRun`s.

Signed-off-by: Andrew Bayer <[email protected]>
@abayer abayer mentioned this issue Jun 12, 2019
Merged
2 tasks
abayer added a commit to abayer/jx that referenced this issue Jun 12, 2019
@abayer
fix(tekton): Set a default PipelineRun timeout of 10 days
5347338 
Starting in Tekton Pipelines v0.4.0, the default timeout for
`TaskRun`s of 10 minutes when no timeout is specified is actually
enforced. The only way to specify a timeout for a `TaskRun` is by
setting a timeout on the `PipelineRun`, so until
tektoncd/pipeline#978 and/or
tektoncd/pipeline#979 are addressed, we
should just set a ridiculously high timeout on all `PipelineRun`s.

Signed-off-by: Andrew Bayer <[email protected]>
@bobcatfish bobcatfish added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 12, 2019
@houshengbo
Copy link

houshengbo commented Jun 12, 2019 •
edited
Loading

/assign @houshengbo
Let me play with the timeout.

jenkins-x-bot pushed a commit to jenkins-x/jx that referenced this issue Jun 13, 2019
@abayer @jenkins-x-bot
fix(tekton): Allow setting pipeline timeout and set default on Pipeli…
791131f 
…neRun to 240 hours (#4251)

* fix(tekton): Set a default PipelineRun timeout of 10 days

Starting in Tekton Pipelines v0.4.0, the default timeout for
`TaskRun`s of 10 minutes when no timeout is specified is actually
enforced. The only way to specify a timeout for a `TaskRun` is by
setting a timeout on the `PipelineRun`, so until
tektoncd/pipeline#978 and/or
tektoncd/pipeline#979 are addressed, we
should just set a ridiculously high timeout on all `PipelineRun`s.

Signed-off-by: Andrew Bayer <[email protected]>

* fix(tekton): Allow configuring Pipeline timeout

Signed-off-by: Andrew Bayer <[email protected]>
@houshengbo
Copy link

@vdemeester @bobcatfish @abayer

First, I'd like to increase the internal default timeout to 60 mins. Is that OK so far?
Then, since the timeout is not limited to taskrun only, I am thinking of creating a new YAML of a new ConfigMap under config dir, e.g. config-default.yaml for the configuration of a configurable timeout key called: defaultTimeoutMinutes.
If defaultTimeoutMinutes is not set, we fall back to the system internal timeout 60 mins. If it is set, we will use defaultTimeoutMinutes as the default timeout across all the tekton resources, if timeout is needed, but not specified.

How does it sound??

@abayer
Copy link
Contributor Author

abayer commented Jun 18, 2019

Sounds reasonable to me!

@bobcatfish
Copy link
Collaborator

Makes sense!

@houshengbo
Copy link

OK, I will implement as described.

@houshengbo houshengbo mentioned this issue Jun 20, 2019
Merged
3 tasks
daveconde pushed a commit to daveconde/jx that referenced this issue Apr 7, 2020
@abayer
fix(tekton): Allow setting pipeline timeout and set default on Pipeli…
7a80085 
…neRun to 240 hours (jenkins-x#4251)

* fix(tekton): Set a default PipelineRun timeout of 10 days

Starting in Tekton Pipelines v0.4.0, the default timeout for
`TaskRun`s of 10 minutes when no timeout is specified is actually
enforced. The only way to specify a timeout for a `TaskRun` is by
setting a timeout on the `PipelineRun`, so until
tektoncd/pipeline#978 and/or
tektoncd/pipeline#979 are addressed, we
should just set a ridiculously high timeout on all `PipelineRun`s.

Signed-off-by: Andrew Bayer <[email protected]>

* fix(tekton): Allow configuring Pipeline timeout

Signed-off-by: Andrew Bayer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@houshengbo houshengbo

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the support of configuring the default timeout of TaskRun
4 participants
@vdemeester @abayer @bobcatfish @houshengbo