Add the support of configuring the default timeout of TaskRun

[houshengbo]

Changes

• Changes the default timeout from 10 mins to 60 mins
• Adds a config_defaults configMap for configuring pipeline default values per tektoncd/pipeline instance

Closes #979

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

The default timeout for TaskRuns and PipelineRuns is increased from 10 minutes to 60 minutes. This timeout will now be configurable.

[bobcatfish]

I think part of your change might be missing from the commit, looking at 2b10d24 it says " Add a new param default_timeout for TaskRun" but the changes look like they only do the first part "Change the default timeout from 10 mins to 60 mins".

Looks like a step in the right direction anyway!

(I hope you don't mind @houshengbo I updated the "release note" section of the PR description)

[bobcatfish]

I think part of your change might be missing from the commit,

Or maybe it's b/c this was a "WIP" in progress PR, in which case my apologies for reviewing too early! 🙏

[houshengbo]

@bobcatfish Thank you for the updates.
It is still under development.

[abayer]

@houshengbo Looks like codegen needs to be run. =)

[abayer]

/assign @abayer

[houshengbo]

@abayer @bobcatfish @vdemeester
I need some suggestions from you folks. I created a store to load the configuration of the default timeout as defined in config-defaults.yaml. Where do I need to load the data, by calling NewStore()?

Should I do it in reconciler for pipelinerun and taskrun? Or should I call is somewhere, so that global context will have it, and can be accessed anywhere in need?
Thx.

[abayer]

I'm wondering if this needs to be this elaborate? We use config-artifact-bucket and config-artifact-pvc just via c.CoreV1().ConfigMap(ns).Get(name, metav1.GetOptions{}) - is that something that we don't think will scale well as we keep adding more configuration?

[houshengbo]

@abayer
I would rather use an existing one, but
do u think config-artifact-pvc or config-artifact-bucket are good candidates to add a global default timeout?

[abayer]

I have no problem with creating a new one, and making it more general, I'm just wondering if we need to be using the approach you're using here to get data from it or if we can use something more like we do with the existing ones.

[dlorenc]

/test pull-tekton-pipeline-go-coverage

[vdemeester]

Seems good to me (and it follows knative/* pattern for those things so yay 🎉)
One remark, we need to start using The Tekton Authors instead of The Knative Authors at some point 👼

/cc @bobcatfish

[linux-foundation-easycla]

All committers are now authorized under a signed CLA.

• ✅ Vincent (d6cb730)

[houshengbo]

/test pull-tekton-pipeline-integration-tests

[houshengbo]

@dlorenc @imjasonh Could you help me review this PR? Thx.

[vdemeester]

This may conflict a tiny bit with #1015 but it's fine 👼
@houshengbo Can you update the commit message to remove * Add a new param default_timeout for TaskRun and add * Adds a config_defaults configMap for configuring pipeline default values per tektoncd/pipeline instance ?

[houshengbo]

@vdemeester Already did it.

[vdemeester]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

Thanks for making this change @houshengbo ! Would it also make sense to add some docs at https://github.com/tektoncd/pipeline/blob/master/docs/install.md#configuring-tekton-pipelines so users know this is something they can configure?