Remove test builders from v1alpha1/pipeline_validation_test.go #3250
Conversation
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XL
| Params: []v1alpha1.Param{{ | ||
| Name: "a-param", | ||
| Value: *v1beta1.NewArrayOrString("first", "value: $(params.baz)", "last"), | ||
| }}, |
There was a problem hiding this comment.
Nothing related to changes in this PR, but wouldnt this test case fail with not defined param just like one above?
There was a problem hiding this comment.
Yeah, good catch. I fixed it, but this highlights the fact that these tests should probably compare the actual returned error, not just whether an error was returned. Simple typos can easily cause cases to go untested this way 😬
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
imjasonh
force-pushed
the
pipeline-validation
branch
from
939c137 to
af188cf
Compare
|
/lgtm |
|
/test pull-tekton-pipeline-integration-tests |
/area testing
/kind cleanup
/assign @pritidesai
#3178
Followup from #3124
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes