Migrate some test builder references to structs

[imjasonh]

Also delete test/builder/ since it appears to be unused.

Before:

$ git grep "tb\." | wc -l
    3579

After:

$ git grep "tb\." | wc -l
    3023

/kind cleanup

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• [y] Includes tests (if functionality changed/added)
• [n/a] Includes docs (if user facing)
• [y] Commit messages follow commit message best practices
• [y] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

/assign @vdemeester

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.0%	97.8%	0.7
test/v1alpha1/wait.go	30.7%	20.5%	-10.2

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.0%	97.8%	0.7

[vdemeester]

Overall seems good to me.

Also delete test/builder/ since it appears to be unused.

Yes, it was kept here to not break downstream consumer of this package. I think it should be ok to remove it now (cc @piyush-garg @pradeepitm12 @dibyom for cli and triggers)

[dibyom]

Thanks for flagging @vdemeester I think triggers still might be using some pipeline builders but I'll try to get rid of them. In any case, I think this PR can be merged -- won't break us until we update pipeline dependency

[imjasonh]

ping @piyush-garg @pradeepitm12 any concerrns with this change?

[pradeepitm12]

ping @piyush-garg @pradeepitm12 any concerrns with this change?

This may require some changes in the tests of cli, but that can be handled.

[piyush-garg]

@imjasonh This may break CLI tests whenever the next bump happens. We are not using the internal pkg, but are dependent on test/builder for CLI tests. I have created an issue in CLI to move to structs. tektoncd/cli#1145

[imjasonh]

So it sounds like people are generally okay with removing test/builders/ and they'll remove references when they bump their dependency to pick up this change. Is that correct? Any other concerns before merging this?

[vdemeester]

/lgtm

[dibyom]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment