Configure user.name in git_test.go run method.
#4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my work to add downstream testing to `knative.dev/pkg` this test is failing with:
```
git_test.go:216: ["error" git]: Error running git [commit --allow-empty -m Hello Moto]: exit status 128
Author identity unknown
*** Please tell me who you are.
Run
git config --global user.email "[email protected]"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for <[email protected]>) not allowed
```
Ref: https://github.com/knative/pkg/pull/2233/checks?check_run_id=3423565615#step:6:528
Tekton already configures `user.email`, but it seems to reject this on Actions without `user.name` as well.
tekton-robot
added
kind/bug
tekton-robot
added
the
size/XS
ghost
approved these changes
Aug 25, 2021
tekton-robot
added
the
approved
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my work to add downstream testing to
knative.dev/pkgthis test is failing with:Ref: https://github.com/knative/pkg/pull/2233/checks?check_run_id=3423565615#step:6:528
Tekton already configures
user.email, but it seems to reject this on Actions withoutuser.nameas well./kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes