-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a few links in the development file under ... #4256
Conversation
fix a few links in the development file under adding New CRD types
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @naosekine. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
DEVELOPMENT.md
Outdated
[pkg/apis/pipeline/v1alpha1](./pkg/apis/pipeline/v1alpha1) e.g | ||
[condition_types.go](./pkg/apis/pipeline/v1alpha1/condition_types.go) This | ||
[pkg/apis/pipeline/v1beta1](./pkg/apis/pipeline/v1beta1) e.g | ||
[condition_types.go](./pkg/apis/pipeline/v1beta1/condition_types.go) This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change condition_types.go
to task_types.go
, conditions are deprecated and do not exist in the beta
API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing @pritidesai !
I committed : f71a32c
DEVELOPMENT.md
Outdated
should implement the | ||
[Defaultable](./pkg/apis/pipeline/v1alpha1/condition_defaults.go) and | ||
[Validatable](./pkg/apis/pipeline/v1alpha1/condition_validation.go) | ||
[Defaultable](./pkg/apis/pipeline/v1beta1/condition_defaults.go) and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly, here please replace condition_defaults.go
with task_defaults.go
And the following line, condition_validation.go
to task_validation.go
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing @pritidesai !
I just committed : f71a32c
Update DEVELOPMENT.md with a few links change
@naosekine I am sorry, its my bad. I didn't realize the section is referring to creating new CRDs and not adding new fields to existing CRDs. The current documentation is pointing to correct API. We might need to update documentation in future when we move from If you are still interested in contributing, we can find some other good-first-issue for you. I apologize once again 🙏 |
@naosekine there are couple of docs with the outdated table of contents, for example, https://github.com/tektoncd/pipeline/blob/main/docs/pipelineruns.md Let me know if you would like to create a PR for it. 🙏 |
Because the following PR wasn't aprroved. tektoncd#4256
@pritidesai Is the place to contact right here? |
You can contact me on Tekton slack. This place is fine temporarily. You can open a GitHub discussion as well to reach to more folks in the community.
Please take a reference of the changes in #4265 to update |
fix a few links in the development file under adding New CRD types
closes #4219
Changes
The Adding New Types section under the DEVELOPMENT.md has a reference to alpha APIs instead of beta. We are now adding a new CRD to beta APIs. No changes being done in alpha APIs.
This commit changes a few links in the development file under adding New CRD types.The detail is to change the link destinations from alpha APIs to v1beta1 APIs.
/kind documentation
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes