fix a few links in the development file under ... #4256
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -471,14 +471,14 @@ If you need to add a new CRD type, you will need to add: | |
| - [clusterrole-aggregate-edit.yaml](./config/clusterrole-aggregate-edit.yaml) | ||
| - [clusterrole-aggregate-view.yaml](./config/clusterrole-aggregate-view.yaml) | ||
| 1. Add go structs for the types in | ||
| [pkg/apis/pipeline/v1beta1](./pkg/apis/pipeline/v1beta1) e.g | ||
| [condition_types.go](./pkg/apis/pipeline/v1beta1/condition_types.go) This | ||
| should implement the | ||
| [Defaultable](./pkg/apis/pipeline/v1beta1/condition_defaults.go) and | ||
|
There was a problem hiding this comment. similarly, here please replace And the following line, There was a problem hiding this comment. Thank you for reviewing @pritidesai ! |
||
| [Validatable](./pkg/apis/pipeline/v1beta1/condition_validation.go) | ||
| interfaces as they are needed for the webhook in the next step. | ||
| 1. Register it with the [webhook](./cmd/webhook/main.go) | ||
| 1. Add the new type to the | ||
| [list of known types](./pkg/apis/pipeline/v1beta1/register.go) | ||
|
|
||
| _See [the API compatibility policy](api_compatibility_policy.md)._ | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change
condition_types.gototask_types.go, conditions are deprecated and do not exist in thebetaAPI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing @pritidesai !
I committed : f71a32c