Fix pvc vs bucket detection case 🌵 #475

vdemeester · 2019-02-05T15:59:47Z

Depending on the config-artifact-bucket configMap, build-pipeline
will create either a PVC or GCS Bucket for sharing output between
task(run)s in the pipeline. There was a bug (or missing case) in the
code that checks if it needs to create PVC.

We want to create a PVC in the following cases:

the config-artifact-bucket configMap is missing
the config-artifact-bucket configMap data is empty
the config-artifact-bucket configMap has no
BucketLocationKey (aka location) or it's value is empty.

The 2nd case wasn't correctly handled between
InitializedArtifactStorage and GetArtifactStorage functions.

/cc @shashwathi

Signed-off-by: Vincent Demeester [email protected]

knative-prow-robot · 2019-02-05T15:59:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abayer · 2019-02-05T16:04:28Z

+1 from me!

vdemeester · 2019-02-05T16:06:31Z

/hold

I'll be adding some unit tests 👼

vdemeester · 2019-02-05T16:41:22Z

/hold cancel

bobcatfish

Thanks for catching this @vdemeester !! just a couple comments about logging/error handling :D

bobcatfish · 2019-02-05T18:46:56Z

pkg/artifacts/artifacts_storage.go

+		if strings.TrimSpace(location) == "" {
+			return true
+		}
+	}


i feel like in some of these cases we should be logging a warning or something, what do you think? if the user provided the configmap but didn't provide the data or url, that seems like they made a mistake? 🤔

@bobcatfish good point, I'll add some logging in there 😉

bobcatfish · 2019-02-05T18:48:14Z

pkg/artifacts/artifacts_storage.go

@@ -68,11 +54,31 @@ func InitializeArtifactStorage(pr *v1alpha1.PipelineRun, c kubernetes.Interface)
 	return NewArtifactBucketConfigFromConfigMap(configMap)
 }

+func needsPVC(configMap *corev1.ConfigMap, err error) bool {
+	if err != nil {
+		return true


hm in this error case we should definitely at least log i think (unless it's a not found error, which we can probably check for explicitly) - if not even fail the run?

good point 👍 didn't change the current behavior but if it's not a not found error, it seems fishy and we may fail the run as a fail early 👼

shashwathi

Great catch. Looks like @bobcatfish has comments so I will leave this upto her to lgtm this PR.

I had a thought when @vdemeester was debugging this. From a user how can I realize from pod spec whether this is using pvc or bucket?
If its bucket storage then pod spec should contain the volume mount pointing to config map and if its PVC then it should have pvc volume mount. The information exists but it is in gigantic pod spec of taskrun.
Can we use labels or annotation to add some meta info to get this info in clear way? Do you think this would have helped you debug faster or better @vdemeester

shashwathi · 2019-02-05T20:56:41Z

/assign @bobcatfish

Depending on the `config-artifact-bucket` configMap, `build-pipeline` will create either a PVC or GCS Bucket for sharing output between task(run)s in the pipeline. There was a bug (or missing case) in the code that checks if it needs to create PVC. We want to create a PVC in the following cases: - the `config-artifact-bucket` configMap is missing - the `config-artifact-bucket` configMap data is empty - the `config-artifact-bucket` configMap has no `BucketLocationKey` (aka `location`) *or* it's value is empty. The 2nd case wasn't correctly handled between `InitializedArtifactStorage` and `GetArtifactStorage` functions. Signed-off-by: Vincent Demeester <[email protected]>

vdemeester · 2019-02-06T11:22:56Z

test/e2e-tests-yaml.sh

-# - https://github.com/knative/build-pipeline/pull/443
-# for test in taskrun pipelinerun; do
-for test in taskrun; do
+for test in taskrun pipelinerun; do


@bobcatfish trying something 🙃 related to #477

vdemeester · 2019-02-06T12:49:52Z

I0206 11:38:57.871] [demo-pipeline-run-1-build-skaffold-web] [build-step-source-copy-skaffold-image-leeroy-web] {"level":"error","ts":1549453114.161359,"logger":"fallback-logger","caller":"bash/main.go:62","msg":"Error executing command \"cp -r /workspace/output/builtImage/. /pvc/build-skaffold-web/builtImage\" with arguments cp: can't stat '/workspace/output/builtImage/.': No such file or directory\n","stacktrace":"main.main\n\t/go/src/github.com/knative/build-pipeline/cmd/bash/main.go:62\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:201"}

ok it's trying to copy /workspace/output/builtImage content, which, I'm guessing is not existing because kaniko push the image (and didn't create anything here) to gcr.io/knative-boskos-14/kbuild-pipeline-e2e-img/leeroy-web:latest

vdemeester · 2019-02-06T12:51:18Z

Removed dba7b6b commit 👼

knative-metrics-robot · 2019-02-06T12:53:03Z

The following is the coverage report on pkg/.
Say /test pull-knative-build-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/artifacts_storage.go	87.0%	82.8%	-4.2

abayer · 2019-02-06T17:27:14Z

/lgtm
/meow space

knative-prow-robot · 2019-02-06T17:27:16Z

@abayer:

In response to this:

/lgtm
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abayer · 2019-02-06T17:35:51Z

Also, because why not:
/meow boxes

knative-prow-robot · 2019-02-06T17:35:52Z

@abayer:

In response to this:

Also, because why not:
/meow boxes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bobcatfish · 2019-02-06T17:44:40Z

ooo boxes, that's a good one @abayer

knative-prow-robot requested a review from shashwathi February 5, 2019 15:59

googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Feb 5, 2019

knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2019

vdemeester mentioned this pull request Feb 5, 2019

Use dag execution instead of linear one #473

Merged

10 tasks

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2019

vdemeester force-pushed the fix-pvc-need-detection branch from ab0587d to 190ac5f Compare February 5, 2019 16:41

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2019

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2019

bobcatfish reviewed Feb 5, 2019

View reviewed changes

shashwathi reviewed Feb 5, 2019

View reviewed changes

knative-prow-robot assigned bobcatfish Feb 5, 2019

vdemeester force-pushed the fix-pvc-need-detection branch 2 times, most recently from 48f9141 to dba7b6b Compare February 6, 2019 11:22

vdemeester commented Feb 6, 2019

View reviewed changes

vdemeester force-pushed the fix-pvc-need-detection branch from dba7b6b to c8f5430 Compare February 6, 2019 12:51

abayer mentioned this pull request Feb 6, 2019

Remove config-artifact-bucket.yaml jenkins-x-charts/tekton#6

Closed

knative-prow-robot assigned abayer Feb 6, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2019

shashwathi mentioned this pull request Feb 6, 2019

Fix README, examples, and re-enable yaml tests 😅 #477

Merged

knative-prow-robot merged commit 6411f05 into tektoncd:master Feb 6, 2019

vdemeester deleted the fix-pvc-need-detection branch February 6, 2019 17:54

vdemeester restored the fix-pvc-need-detection branch February 26, 2019 09:17

vdemeester deleted the fix-pvc-need-detection branch February 26, 2019 09:17

mchmarny unassigned abayer Mar 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix pvc vs bucket detection case 🌵 #475

Fix pvc vs bucket detection case 🌵 #475

vdemeester commented Feb 5, 2019

knative-prow-robot commented Feb 5, 2019

abayer commented Feb 5, 2019

vdemeester commented Feb 5, 2019

vdemeester commented Feb 5, 2019

bobcatfish left a comment

bobcatfish Feb 5, 2019

vdemeester Feb 6, 2019

bobcatfish Feb 5, 2019

vdemeester Feb 6, 2019

shashwathi left a comment

shashwathi commented Feb 5, 2019

vdemeester Feb 6, 2019

bobcatfish Feb 6, 2019

vdemeester commented Feb 6, 2019

vdemeester commented Feb 6, 2019 •

edited

Loading

knative-metrics-robot commented Feb 6, 2019

abayer commented Feb 6, 2019

knative-prow-robot commented Feb 6, 2019

abayer commented Feb 6, 2019

knative-prow-robot commented Feb 6, 2019

bobcatfish commented Feb 6, 2019

Fix pvc vs bucket detection case 🌵 #475

Fix pvc vs bucket detection case 🌵 #475

Conversation

vdemeester commented Feb 5, 2019

knative-prow-robot commented Feb 5, 2019

abayer commented Feb 5, 2019

vdemeester commented Feb 5, 2019

vdemeester commented Feb 5, 2019

bobcatfish left a comment

Choose a reason for hiding this comment

bobcatfish Feb 5, 2019

Choose a reason for hiding this comment

vdemeester Feb 6, 2019

Choose a reason for hiding this comment

bobcatfish Feb 5, 2019

Choose a reason for hiding this comment

vdemeester Feb 6, 2019

Choose a reason for hiding this comment

shashwathi left a comment

Choose a reason for hiding this comment

shashwathi commented Feb 5, 2019

vdemeester Feb 6, 2019

Choose a reason for hiding this comment

bobcatfish Feb 6, 2019

Choose a reason for hiding this comment

vdemeester commented Feb 6, 2019

vdemeester commented Feb 6, 2019 • edited Loading

knative-metrics-robot commented Feb 6, 2019

abayer commented Feb 6, 2019

knative-prow-robot commented Feb 6, 2019

abayer commented Feb 6, 2019

knative-prow-robot commented Feb 6, 2019

bobcatfish commented Feb 6, 2019

vdemeester commented Feb 6, 2019 •

edited

Loading