Fix README, examples, and re-enable yaml tests 😅 #477
Conversation
googlebot
added
the
cla: yes
knative-prow-robot
added
size/S
bobcatfish
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish, shashwathi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This PR needs fix from #479 |
I tried to run the examples this morning and found that the docs were wrong and also that the path in the example pipelines was now incorrect. I can see how the docs could get out of sync but something odd is happening with the pipeline paths b/c our tests should be catching that, so I'll open a bug. In the meantime, these changes make it so we can at least successfully create the pipelinerun (also tried the taskrun, which works - I haven't tried the other examples).
Verifying the pipelinerun example worked was disabled due to the combo of tektoncd#375 and tektoncd#443, but now that we've removed the extra log PVC in tektoncd#443 we shouldn't run into this issue anymore :D
bobcatfish
force-pushed
the
fix_yaml_examples
branch
from
5cee53d to
e9b6901
Compare
|
Rebased hopefully that does it 🤞 |
|
This PR needs #475 fix as well(I thought). |
|
/lgtm |
|
hm the timeout tests are failing, interesting, maybe related to #456? (did we already make the resync change 🤔 ) |
|
/test pull-knative-build-pipeline-integration-tests |
|
We have not added the resync change. I have triggered it again to see if this is a flaky test or valid error. |
😥 |
I tried to run the examples this morning and found that the docs were
wrong and also that the path in the example pipelines was now incorrect.
In 411bc55 we disabled the pipelinerun tests due to the PVC issue, but now that #443 is done we should be able to re-enable them hopefully! 🎉