Remove deprecated Conditions CRD/functionality #4942

abayer · 2022-06-06T22:54:00Z

Changes

Closes #3377

This was deprecated in v0.16.0, and is scheduled to be fully removed in v0.37.0, releasing late in June.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Docs included if any changes are user facing
Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Release notes block below has been filled in
(if there are no user facing changes, use release note "NONE")

Release Notes

action required: Deprecated `conditions` in pipelines removed. Existing pipelines using `conditions` will need to be updated.

abayer · 2022-06-06T22:54:28Z

/assign @lbernick
/assign @afrittoli
/assign @vdemeester
/assign @jerop

abayer · 2022-06-06T22:54:56Z

I need to add the release note, but it's 7pm here and I wanted to open this PR right before I flee to eat. =)

tekton-robot · 2022-06-06T22:56:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_conversion.go	91.6%	91.4%	-0.2
pkg/apis/pipeline/v1beta1/pipeline_types.go	96.6%	96.5%	-0.1
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	81.1%	86.5%	5.5
pkg/reconciler/pipelinerun/pipelinerun.go	86.4%	86.1%	-0.3
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	92.0%	93.4%	1.4
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.2%	97.4%	0.2
test/controller.go	24.0%	25.3%	1.3
test/v1alpha1/controller.go	37.5%	39.5%	2.0

lbernick

🎉

Thanks Andrew! Make sure you remove the Condition CRD from config/, and grep for it in the docs (there are a number of other places where it exists in the docs)

abayer · 2022-06-06T23:40:07Z

@lbernick Yeah, this is still a draft for a reason. =)

tekton-robot · 2022-06-07T12:48:27Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_conversion.go	91.6%	91.4%	-0.2
pkg/apis/pipeline/v1beta1/pipeline_types.go	96.6%	96.5%	-0.1
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	81.1%	86.5%	5.5
pkg/reconciler/pipelinerun/pipelinerun.go	86.4%	86.1%	-0.3
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	92.0%	93.4%	1.4
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.2%	97.4%	0.2
test/controller.go	24.0%	25.3%	1.3
test/v1alpha1/controller.go	37.5%	39.5%	2.0

jerop · 2022-06-07T13:59:34Z

excited that we're finally removing conditions, thank you @abayer 🎉

tekton-robot · 2022-06-07T14:22:52Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_conversion.go	91.6%	91.4%	-0.2
pkg/apis/pipeline/v1beta1/pipeline_types.go	96.6%	96.5%	-0.1
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	81.1%	86.5%	5.5
pkg/reconciler/pipelinerun/pipelinerun.go	86.4%	86.1%	-0.3
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	92.0%	93.4%	1.4
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.2%	97.4%	0.2
test/controller.go	24.0%	25.3%	1.3
test/v1alpha1/controller.go	37.5%	39.5%	2.0

tekton-robot · 2022-06-07T15:00:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_conversion.go	91.6%	91.4%	-0.2
pkg/apis/pipeline/v1beta1/pipeline_types.go	96.6%	96.5%	-0.1
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	81.1%	86.5%	5.5
pkg/reconciler/pipelinerun/pipelinerun.go	86.4%	86.1%	-0.3
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	92.0%	93.4%	1.4
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.2%	97.4%	0.2
test/controller.go	24.0%	25.3%	1.3
test/v1alpha1/controller.go	37.5%	39.5%	2.0

abayer · 2022-06-07T18:57:05Z

/retest

Starting with Pipeline v0.37.0, after tektoncd/pipeline#4942 merges, `conditions` will no longer be part of Pipeline. This removes references to `conditions` from the release tooling. Signed-off-by: Andrew Bayer <[email protected]>

tekton-robot · 2022-06-07T19:51:37Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_conversion.go	91.6%	91.4%	-0.2
pkg/apis/pipeline/v1beta1/pipeline_types.go	96.6%	96.5%	-0.1
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	81.1%	86.5%	5.5
pkg/reconciler/pipelinerun/pipelinerun.go	86.4%	86.1%	-0.3
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	92.0%	93.4%	1.4
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.2%	97.4%	0.2
test/controller.go	24.0%	25.3%	1.3
test/v1alpha1/controller.go	37.5%	39.5%	2.0

docs/conditions.md

pkg/apis/pipeline/v1alpha1/pipeline_types.go

pkg/reconciler/pipelinerun/resources/pipelinerunstate.go

Closes tektoncd#3377 This was deprecated in v0.16.0, and is scheduled to be fully removed in v0.37.0, releasing late in June. Signed-off-by: Andrew Bayer <[email protected]>

jerop

thank you @abayer 🎉

tekton-robot · 2022-06-07T21:04:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jerop,lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jerop · 2022-06-07T21:05:42Z

/lgtm

jerop · 2022-06-07T21:09:12Z

@abayer we need to update the deprecations table (remove conditions) - https://github.com/abayer/tektoncd-pipeline/blob/remove-conditions/docs/deprecations.md

abayer · 2022-06-07T21:21:19Z

/retest

tekton-robot · 2022-06-07T21:23:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_conversion.go	91.6%	91.4%	-0.2
pkg/apis/pipeline/v1alpha1/pipeline_types.go	72.7%	83.3%	10.6
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.0%	96.9%	-0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go	96.6%	96.5%	-0.1
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	81.1%	86.5%	5.5
pkg/reconciler/pipelinerun/pipelinerun.go	86.4%	86.1%	-0.3
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	92.0%	93.4%	1.4
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.2%	97.4%	0.2
test/controller.go	24.0%	25.3%	1.3
test/v1alpha1/controller.go	37.5%	39.5%	2.0

pritidesai · 2022-06-07T22:09:29Z

pkg/reconciler/pipelinerun/pipelinerun_updatestatus_test.go

@@ -50,7 +50,7 @@ var (
 )

 type updateStatusTaskRunsData struct {
-	withConditions map[string]*v1beta1.PipelineRunTaskRunStatus
+	noTaskRuns     map[string]*v1beta1.PipelineRunTaskRunStatus


withConditions to noTaskRuns? 🤔 What is this intended to test?

pritidesai · 2022-06-07T22:11:09Z

pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go

@@ -78,7 +67,6 @@ type ResolvedPipelineRunTask struct {
 	PipelineTask          *v1beta1.PipelineTask
 	ResolvedTaskResources *resources.ResolvedTaskResources
 	// ConditionChecks ~~TaskRuns but for evaling conditions


should this be deleted too? 🤔

pritidesai · 2022-06-07T22:50:05Z

    stream.go:238: Invalid log format for pod tekton-pipelines-controller-868b496cf4-bpqz7: {"level":"info","ts":"2022-06-07T21:56:12.144Z","logger":"tekton-pipelines-controller","caller":"pipelinerun/pipelinerun.go:860","msg":"Creating a new Run object pipeline-run-custom-task-timeout-njpnomco-custom-task-ref","commit":"03322f3","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.pipelinerun.Reconciler","knative.dev/kind":"tekton.dev.PipelineRun","knative.dev/traceid":"22af9bdc-516d-48bf-90b9-22ec3aedb35f","knative.dev/key":"arendelle-vx9qh/pipeline-run-custom-task-timeout-njpnomco"}

🤔

abayer · 2022-06-07T22:52:58Z

/retest

abayer · 2022-06-07T22:53:42Z

That’s nothing to worry about - it’s just #4777.

`Conditions` were removed in tektoncd#4942. In this change, we remove the deprecation and removal notice for `Conditions` from the deprecations table. We also remaining references to `Conditions`. Related issue: tektoncd#3377.

`Conditions` were removed in #4942. In this change, we remove the deprecation and removal notice for `Conditions` from the deprecations table. We also remaining references to `Conditions`. Related issue: #3377.

In tektoncd#4942, we removed `Conditions`. However, there was some logic that was left over. In this change, we clean up the remaining logic for `Conditions`.

In tektoncd#4942, we removed `Conditions`. However, there was some logic that was left over. In this change, we clean up the remaining logic for `Conditions`. Issue: tektoncd#3377

In #4942, we removed `Conditions`. However, there was some logic that was left over. In this change, we clean up the remaining logic for `Conditions`. Issue: #3377

Starting with Pipeline v0.37.0, after tektoncd/pipeline#4942 merges, `conditions` will no longer be part of Pipeline. This removes references to `conditions` from the release tooling. Signed-off-by: Andrew Bayer <[email protected]>

tekton-robot requested review from dlorenc and imjasonh June 6, 2022 22:54

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 6, 2022

tekton-robot assigned afrittoli, jerop, lbernick and vdemeester Jun 6, 2022

lbernick reviewed Jun 6, 2022

View reviewed changes

tekton-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 7, 2022

abayer mentioned this pull request Jun 7, 2022

Remove conditions from release tooling tektoncd/plumbing#1089

Merged

2 tasks

abayer force-pushed the remove-conditions branch from 4bbb8fa to de82868 Compare June 7, 2022 19:49

abayer marked this pull request as ready for review June 7, 2022 19:49

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2022

lbernick approved these changes Jun 7, 2022

View reviewed changes

docs/conditions.md Show resolved Hide resolved

pkg/apis/pipeline/v1alpha1/pipeline_types.go Outdated Show resolved Hide resolved

pkg/reconciler/pipelinerun/resources/pipelinerunstate.go Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022

Remove deprecated Conditions CRD/functionality

dc8a1db

Closes tektoncd#3377 This was deprecated in v0.16.0, and is scheduled to be fully removed in v0.37.0, releasing late in June. Signed-off-by: Andrew Bayer <[email protected]>

abayer force-pushed the remove-conditions branch from de82868 to dc8a1db Compare June 7, 2022 20:42

jerop approved these changes Jun 7, 2022

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2022

pritidesai reviewed Jun 7, 2022

View reviewed changes

tekton-robot merged commit 9d60d0a into tektoncd:main Jun 7, 2022

This was referenced Jun 8, 2022

Remove Conditions from deprecations table #4946

Merged

TEP-0090: Split up ResolvePipelineRunTask #4943

Merged

TEP-0090: Indicate Resolved PipelineRunTask is Matrixed #4945

Merged

jerop added a commit to jerop/pipeline that referenced this pull request Jun 23, 2022

Finish up removal of Conditions 🧹

8151ee0

In tektoncd#4942, we removed `Conditions`. However, there was some logic that was left over. In this change, we clean up the remaining logic for `Conditions`.

jerop mentioned this pull request Jun 23, 2022

Finish up removal of Conditions 🧹 #5027

Merged

3 tasks

tekton-robot pushed a commit that referenced this pull request Jun 23, 2022

Finish up removal of Conditions 🧹

3fd7138

In #4942, we removed `Conditions`. However, there was some logic that was left over. In this change, we clean up the remaining logic for `Conditions`. Issue: #3377

vdemeester mentioned this pull request Jun 24, 2022

Remove Condition subcommand tektoncd/cli#1620

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated Conditions CRD/functionality #4942

Remove deprecated Conditions CRD/functionality #4942

abayer commented Jun 6, 2022 •

edited

Loading

abayer commented Jun 6, 2022

abayer commented Jun 6, 2022

tekton-robot commented Jun 6, 2022

lbernick left a comment

abayer commented Jun 6, 2022

tekton-robot commented Jun 7, 2022

jerop commented Jun 7, 2022

tekton-robot commented Jun 7, 2022

tekton-robot commented Jun 7, 2022

abayer commented Jun 7, 2022

tekton-robot commented Jun 7, 2022

jerop left a comment

tekton-robot commented Jun 7, 2022

jerop commented Jun 7, 2022

jerop commented Jun 7, 2022

abayer commented Jun 7, 2022

tekton-robot commented Jun 7, 2022

pritidesai Jun 7, 2022

pritidesai Jun 7, 2022

pritidesai commented Jun 7, 2022

abayer commented Jun 7, 2022

abayer commented Jun 7, 2022

Remove deprecated Conditions CRD/functionality #4942

Remove deprecated Conditions CRD/functionality #4942

Conversation

abayer commented Jun 6, 2022 • edited Loading

Changes

Submitter Checklist

Release Notes

abayer commented Jun 6, 2022

abayer commented Jun 6, 2022

tekton-robot commented Jun 6, 2022

lbernick left a comment

Choose a reason for hiding this comment

abayer commented Jun 6, 2022

tekton-robot commented Jun 7, 2022

jerop commented Jun 7, 2022

tekton-robot commented Jun 7, 2022

tekton-robot commented Jun 7, 2022

abayer commented Jun 7, 2022

tekton-robot commented Jun 7, 2022

jerop left a comment

Choose a reason for hiding this comment

tekton-robot commented Jun 7, 2022

jerop commented Jun 7, 2022

jerop commented Jun 7, 2022

abayer commented Jun 7, 2022

tekton-robot commented Jun 7, 2022

pritidesai Jun 7, 2022

Choose a reason for hiding this comment

pritidesai Jun 7, 2022

Choose a reason for hiding this comment

pritidesai commented Jun 7, 2022

abayer commented Jun 7, 2022

abayer commented Jun 7, 2022

abayer commented Jun 6, 2022 •

edited

Loading