Finish up removal of Conditions 🧹
#5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tektoncd#4942, we removed `Conditions`. However, there was some logic that was left over. In this change, we clean up the remaining logic for `Conditions`. Issue: tektoncd#3377
tekton-robot
added
release-note-none
tekton-robot
added
the
size/M
vdemeester
approved these changes
Jun 23, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
The following is the coverage report on the affected files.
|
jerop
commented
Jun 23, 2022
Comment on lines
-269
to
-272
| case n == "dagtask3": | ||
| if !isSkipped(t, n, taskrunItem.Status.Conditions) { | ||
| t.Fatalf("dag task %s should have skipped due to condition failure", n) | ||
| } |
There was a problem hiding this comment.
for reviewers' convenience, "dagtask3" was migrated to use when expressions and is in skipped tasks section of pipelinerun status now - see line 342 to line 349
|
/lgtm Ooops, I did miss a little bit. =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In #4942, we removed
Conditions. However, there was some logic that was left over. In this change, we clean up the remaining logic forConditions.Issue: #3377
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes