Timeout handler : WaitTaskRun only if the pod got created successfully #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can save one goroutines per pod creation by waiting for TaskRun only if the pod creation was successful. Signed-off-by: Vincent Demeester <[email protected]>
googlebot
added
the
cla: yes
tekton-robot
added
approved
|
cc @shashwathi if I missed something 😅 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shashwathi, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 26, 2019
ghost
mentioned this pull request
3 tasks
tekton-robot
pushed a commit
that referenced
this pull request
Apr 19, 2019
This WaitTaskRun call was moved in a commit but then reinstated the following day. Looks like this being reinstated was an artifact of a rebase for a separate PR and the removal of the call was the correct thing to do. The original change message for this removal is as follows: > We can save one goroutines per pod creation by waiting for TaskRun > only if the pod creation was successful. This was the original PR with the call removal: #674 And then it looks like it was reinstated here: https://github.com/tektoncd/pipeline/pull/648/files#diff-b52b9f382ad878e6aa2a85921bb19065R287
wlynch
pushed a commit
to wlynch/pipeline
that referenced
this pull request
May 20, 2019
This WaitTaskRun call was moved in a commit but then reinstated the following day. Looks like this being reinstated was an artifact of a rebase for a separate PR and the removal of the call was the correct thing to do. The original change message for this removal is as follows: > We can save one goroutines per pod creation by waiting for TaskRun > only if the pod creation was successful. This was the original PR with the call removal: tektoncd#674 And then it looks like it was reinstated here: https://github.com/tektoncd/pipeline/pull/648/files#diff-b52b9f382ad878e6aa2a85921bb19065R287
wlynch
pushed a commit
to wlynch/pipeline
that referenced
this pull request
May 20, 2019
This WaitTaskRun call was moved in a commit but then reinstated the following day. Looks like this being reinstated was an artifact of a rebase for a separate PR and the removal of the call was the correct thing to do. The original change message for this removal is as follows: > We can save one goroutines per pod creation by waiting for TaskRun > only if the pod creation was successful. This was the original PR with the call removal: tektoncd#674 And then it looks like it was reinstated here: https://github.com/tektoncd/pipeline/pull/648/files#diff-b52b9f382ad878e6aa2a85921bb19065R287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We can save one goroutines per pod creation by waiting for TaskRun
only if the pod creation was successful.
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
[ ] Includes tests (if functionality changed/added)[ ] Includes docs (if user facing)See the contribution guide
for more details.