Timeout handler : WaitPipelineRun only if we're ready to create TaskRuns

[vdemeester]

Changes

We can save one goroutines per PipelineRun by starting the wait
goroutine just before creating TaskRuns.

It's a bit related to #674, but for pipelinerun, trying to reduce potential number of goroutines whenever we can. In the case of pipelinerun, we can wait a bit before starting the wait, as Wait will take the StartTime into account (which is created really early) — that way, if something fails to validate (Pipeline reference not found, …), we won't even create a goroutine.

/cc @shashwathi correct me if I'm wrong 👼 😝

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• [ ] Includes tests (if functionality changed/added)
• [ ] Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide
for more details.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shashwathi]

@vdemeester : This change will create race conditions. InitializeConditions updates StartTime in status and this needs to be accessed in mutex only

We can save one goroutines per PipelineRun by starting the wait
goroutine just before creating TaskRuns.

I do not understand how is this change saving goroutine. If pipelineRun has started then no goroutine will be created

[vdemeester]

I do not understand how is this change saving goroutine. If pipelineRun has started then no goroutine will be created

@shashwathi oh good point, I forgot about that 😅

Right, so that won't work indeed… I was trying to not start the wait goroutine as long as possible (aka up until lots of validation happens). But yeah, as is, it won't work — I'll close, back to the drawing board 👼 😄