Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enter_verb pattern is set to "Regular expression", should be "Command pattern" #1121

Closed
KVonGit opened this issue May 10, 2021 · 3 comments · Fixed by #1319
Closed

enter_verb pattern is set to "Regular expression", should be "Command pattern" #1121

KVonGit opened this issue May 10, 2021 · 3 comments · Fixed by #1319

Comments

@KVonGit
Copy link
Collaborator

KVonGit commented May 10, 2021

I already have a pending pull request.

I would create one to fix this issue, but I don't want to get any pull requests crossed.
@KVonGit
Copy link
Collaborator Author

KVonGit commented May 11, 2021 •
edited
Loading

Looks like we should replace this with:

  BAD CODE REMOVED
  SEE NEXT COMMENT

https://textadventures.co.uk/forum/samples/topic/-ygnjpim-kmbpbj44zznva/attention-quest-authors-who-use-the-enter-verb#e5f4fdec-1d03-466b-92ef-74d02561113c

@KVonGit
Copy link
Collaborator Author

KVonGit commented May 11, 2021

Nope. That broke a game with the existing enter_verb copied into it.

I had to change the property to "enter_verb" so it named it correctly (like the existing one).

  <verbtemplate name="enter_verb">enter</verbtemplate>
  <dynamictemplate name="DefaultEnter">WriteVerb(game.pov, "can't") + " enter " + object.article + "."</dynamictemplate>
  <verb template="enter_verb" property="enter_verb" response="DefaultEnter"/>

@KVonGit
Copy link
Collaborator Author

KVonGit commented May 12, 2021

UPDATE (sort of)

I don't fully understand verbs.

See that forum thread (posted two comments ago) to see what mrangel added to the discussion. What he's saying definitely sounds right, but I still don't fully grasp everything you always wanted to know about verbs but were afraid to ask.

@KVonGit KVonGit mentioned this issue Sep 3, 2024
Closed
@KVonGit KVonGit mentioned this issue Nov 18, 2024
Closed
TextMisadventures added a commit to TextMisadventures/quest that referenced this issue Nov 25, 2024
@TextMisadventures
Fix Bugs Introduced in 580
5ddb102 
- transcript
  - added missing function to player.js
  - changed desktop player file saving format from HTML to TXT
  - added localStorage functionality for the web player
  - removed in-game transcript viewing
  - automatically uses game name for transcript name when command bar is hidden

Closes textadventures#1054

---
- log
  - restored log window in the desktop player
  - removed ability to view the log in-game

Closes textadventures#1025

---
- AllRooms()
  - fixed by @Pertex

Closes textadventures#1202

---
- setBackground()
  - fixed by @ThePix

Closes textadventures#1052

---
- enter_verb
  - fix stolen from mrangel forum post

Closes textadventures#1121

---
- save command
  - now uses `saveGame()` when online
  - scrolls when printing saveGameResponse messages

Closes textadventures#1200

---
- DictionaryRemove
  - fixed typo

---
- update transcript.md doc

---

Tidy up language files

- remove code that "includes" EditorEnglish.aslx when English.aslx is already included

---
Addition submitted by @Pertex

Added option to use custom image in the location bar, complete with editor controls
This was referenced Nov 25, 2024
Merged
Closed
KVonGit added a commit to KVonGit/quest that referenced this issue Dec 29, 2024
@KVonGit
Fix issue with enter_verb pattern type
cfc813e 
Closes textadventures#1121

https://textadventures.co.uk/forum/samples/topic/-ygnjpim-kmbpbj44zznva/attention-quest-authors-who-use-the-enter-verb#c959d61d-235e-4d4e-b9a8-73e1dbd73fcb
@KVonGit KVonGit mentioned this issue Dec 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@KVonGit