Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebPlayer - SAVE Command does not save divOutput #1200

Open
KVonGit opened this issue Oct 4, 2024 · 1 comment
Open

WebPlayer - SAVE Command does not save divOutput #1200

KVonGit opened this issue Oct 4, 2024 · 1 comment

Comments

@KVonGit
Copy link
Collaborator

KVonGit commented Oct 4, 2024

Online, if you click the Save button, everything works correctly when you load your saved game.

However, if you enter the SAVE command instead, the game's text is not restored when you load your saved game.

Looks like a possible fix was posted in this thread: https://textadventures.co.uk/forum/quest/topic/5fd2-liccuidcbbf_eiefa/log-im-trying-to-figure-out-how-to-save-the-content-to-a-file#f91f54ac-f3e9-480a-b98b-83db552b4b4e

If I find a fix during testing, I will create a pull request.
@KVonGit KVonGit mentioned this issue Oct 14, 2024
Closed
@KVonGit KVonGit mentioned this issue Nov 18, 2024
Closed
TextMisadventures added a commit to TextMisadventures/quest that referenced this issue Nov 25, 2024
@TextMisadventures
Fix Bugs Introduced in 580
5ddb102 
- transcript
  - added missing function to player.js
  - changed desktop player file saving format from HTML to TXT
  - added localStorage functionality for the web player
  - removed in-game transcript viewing
  - automatically uses game name for transcript name when command bar is hidden

Closes textadventures#1054

---
- log
  - restored log window in the desktop player
  - removed ability to view the log in-game

Closes textadventures#1025

---
- AllRooms()
  - fixed by @Pertex

Closes textadventures#1202

---
- setBackground()
  - fixed by @ThePix

Closes textadventures#1052

---
- enter_verb
  - fix stolen from mrangel forum post

Closes textadventures#1121

---
- save command
  - now uses `saveGame()` when online
  - scrolls when printing saveGameResponse messages

Closes textadventures#1200

---
- DictionaryRemove
  - fixed typo

---
- update transcript.md doc

---

Tidy up language files

- remove code that "includes" EditorEnglish.aslx when English.aslx is already included

---
Addition submitted by @Pertex

Added option to use custom image in the location bar, complete with editor controls
This was referenced Nov 25, 2024
Merged
Closed
KVonGit added a commit to KVonGit/quest that referenced this issue Dec 31, 2024
@KVonGit
textadventures#1200 clearScreen function no longer deletes outputData…
4f3d53b 
… element

Move `#outputData` out of `#divOutput` before clearing the screen, then back at the end of the function. This is to retain the data after saving/resuming play online.

Closes textadventures#1200
@KVonGit
Copy link
Collaborator Author

KVonGit commented Dec 31, 2024 •
edited
Loading

PR coming as soon as CoreCommands.aslx is "free"

save

      if (StartsWith(GetFileURL("foo"), "quest")) {
         request(RequestSave, "")
      }
      else {
        JS.saveGame ()
      }
      else {
        request(RequestSave, "")
      }
      SuppressTurnscripts

@KVonGit KVonGit mentioned this issue Jan 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@KVonGit