Fix bugs introduced in 580 #1240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- transcript - added missing function to player.js - changed desktop player file saving format from HTML to TXT - added localStorage functionality for the web player - removed in-game transcript viewing - automatically uses game name for transcript name when command bar is hidden Closes textadventures#1054 --- - log - restored log window in the desktop player - removed ability to view the log in-game Closes textadventures#1025 --- - AllRooms() - fixed by @Pertex Closes textadventures#1202 --- - setBackground() - fixed by @ThePix Closes textadventures#1052 --- - enter_verb - fix stolen from mrangel forum post Closes textadventures#1121 --- - save command - now uses `saveGame()` when online - scrolls when printing saveGameResponse messages Closes textadventures#1200 --- - DictionaryRemove - fixed typo --- - update transcript.md doc --- Tidy up language files - remove code that "includes" EditorEnglish.aslx when English.aslx is already included --- Addition submitted by @Pertex Added option to use custom image in the location bar, complete with editor controls
Had to move the line where it clears the input bar
Using JS `getTimeAndDateForLog`
Set `platform` to "desktop". (Moving this from playercore.js to this file, since playercore.js is shared by all platforms.)
https://textadventures.co.uk/forum/quest/topic/ykouw7idaeytupcl3rmywa/isnt-there-an-easy-way-to-add-text-processor-commands#b6d3a7cd-a2a8-42c6-a9b7-d74a76d40f62 > You can do `{:span id="spoooon"}spoon?{/span}` or whatever if you're getting frustrated with the online editor :) --- Also added `@@@lt@@@` to be replaced with `<`, like `@@@OPEN@@@` is replaced with `{`.
Better late than never
I modified GetListDisplayAlias to use the text processor if an object's listalias attribute was defined as a string.
Using an image like {img:foo.png} will cause errors when clicking the verb buttons in the pane.
Closes textadventures#1259
Handle alias including a `.` when `game.multiplecommands` is `true` Fix error in ProcessTextCommand_Element
Closes textadventures#1284 Some of the templates are not all lower-case. This will make both the command and the value of the template(s) lower-case before comparing them. Co-Authored-By: Pertex <[email protected]>
|
I'm not satisfied with the way the transcripts are accessed online.
|
Closes textadventures#1297 > Currently to move the player you have to move game.pov, and this is commonly confused with the ChangePOV function. So let's add a "move player" function to live alongside "move object", which should be nice and easy to find. - Alex
Users occasionally use ChangePOV thinking it will move the player. This will now throw an error if the object has no parent object. Closes textadventures#1298
Changed the `ShowMenu` link from `ASLEvent` to `msg` in earlier commit. This changes it back. Also add code to print the response to `ShowMenu` with a new template `ShowMenuResponsePrompt` which is `>>` in **English.aslx** Co-Authored-By: Pertex <[email protected]>
Replace ` ` with ` ` before writing to transcript
alexwarren
requested changes
Dec 27, 2024
|
That's no problem at all. I was just thinking I should do this the other day.
Most of these fixes involve the same files, though; so, submitting them all at once didn't work out well, because each branch had to build off the last to avoid conflicts, and the 19th PR was the equivalent of this one. I'd like to have them all submitted and ready to go, of course (for days like today, haha), but the only other approach I know of is to submit one fix at a time. When each gets merged (or finalized if not merged), then I'll submit the next. (If you have a better approach, I'd be down for that, of course. I'm not as GitHub-savvy as I'd like to be.) |
|
I think one fix at a time is the way to go, and I'll try to review them promptly (this next week or so is good while I'm on a break from work). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Bugs Introduced in 580
Closes #1054
Closes #1025
Closes #1202
LCase(command)failed sometimesFixed by @Pertex
Closes #1284
Closes #1052
Closes #1121
saveGame()when onlineCloses #1200
Fix issue with
.in alias whengame.multiplecommandsistrueCloses #1270
Fix issue with GetListDisplayAlias
I modified GetListDisplayAlias to use the text processor if an object's listalias attribute was defined as a string.
Using an image like {img:foo.png} will cause errors when clicking the verb buttons in the pane.
Closes #1259
Tidy up language files
Addition submitted by @Pertex
Added option to use custom image in the location bar, complete with editor controls