feat: Add a new method to get the number of CPU cores to use for parallelism #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @Wirone |
Wirone
reviewed
Jul 24, 2024
2 tasks
1 task
theofidry
added a commit
that referenced
this pull request
Jul 29, 2024
I would like to make cases like PHP-CS-Fixer/PHP-CS-Fixer#8129 easier to debug. There is 3 things to check: - If each respective finder behaves as expected, this is the job of the `diagnose.php`. - Which finder result got picked: the introduce `CpuCoreFinder::trace()` should answer that. - A way to debug `CpuCoreFinder::getAvailableForParallelisation()`. Since #127 is not released yet, the signature of `::getAvailableForParallelisation()` to return a result value object which could capture the resolved parameters to be able to figure out with which values the calculation was done.
|
Finally able to confirm this: Thank you!, @theofidry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the current primitives offered by the library are fine. What is not is that people use
$counter->getCount()with the expectation that it is the number of cores they should use for parallelism (and it is the usage I've defaulted to as well, as this is how it was used in the original code that this library was taken from). But as highlighted in #125, it is not. A non exhaustive list:Seeing
uv_available_parallelism, I've decide to introduce a new API that can address those points and make it easier for consumers to get the appropriate number of cores for the purpose of knowing the number of processes they can launch for parallelism, which is the main usage of this library.I will add more parameters in the future to address the points mentioned above, but they will be added as default parameters hence will not break the API.