Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to make cases like PHP-CS-Fixer/PHP-CS-Fixer#8129 easier to debug. There is 3 things to check:
diagnose.php
.CpuCoreFinder::trace()
should answer that.CpuCoreFinder::getAvailableForParallelisation()
**: this is more tricky as:
What I am thinking is, since #127 is not released yet, I could change the signature of
::getAvailableForParallelisation()
to return a result value object which could capture the resolved parameters to be able to figure out with which values the calculation was done.What I am unsure of, is if it should contain the trace introduced there too, and if done it likely would need to be lazily executed as this would execute several additional system calls.