WIP: Reinstate Azure Blob Storage support #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a useful PR indeed, thanks! It seems you'll need to adapt the CI to install the package (and run tests) only in PHP 8.0+ as it's required (no version of the package supporting PHP 7 is available AFAICT). |
|
In order to get this to work while still maintaining PHP 7.2 support it's going to need to add a lot of conditional checks throughout the tests. I haven't been able to get it fully working, but it's already rather messy. |
Merged
|
Closing as this will be supported in #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just reverted the deleted files from #59
Test cases pass.
I still need to test manually against Azure hence the WIP status