Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 3 #115

Merged
merged 8 commits into from
Sep 12, 2022
Merged

Version 3 #115

merged 8 commits into from
Sep 12, 2022

Conversation

nspyke
Copy link
Contributor

@nspyke nspyke commented Sep 4, 2022 •
edited
Loading

  • Added Azure Blob Storage support
  • Dropped support for Symfony 4.2 to 5.3
  • Dropped support for PHP 7.2 - 7.4
  • Dropped support for Flysystem v2
  • Dropped support for v2 adapter versions

Version 3 as suggested in #112

tgalopin
tgalopin reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@tgalopin tgalopin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also update the README requirements sentence to show the change?

@nspyke
Copy link
Contributor Author

nspyke commented Sep 8, 2022

Hi @tgalopin
Changes have been made as requested

@nspyke nspyke mentioned this pull request Sep 8, 2022
Closed
tgalopin
tgalopin approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@tgalopin tgalopin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few slight changes and we're good to go! Thanks :)

@nspyke
Copy link
Contributor Author

nspyke commented Sep 8, 2022 •
edited
Loading

Before tagging 3.0, can I suggest looking at reviewing and merging some of the other open pull requests?
#100, #107, #108, #109 look like good candidates. #114 is a duplicate of #100.
If the original PR authors are not available to make review changes, I'd be happy to do so.

@tgalopin tgalopin merged commit ae7a9d0 into thephpleague:master Sep 12, 2022
@tgalopin
Copy link
Member

Thanks a lot for this PR!

@maxhelias maxhelias mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgalopin tgalopin tgalopin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nspyke @tgalopin @airnzspijkn