Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing public_url configuration option #119

Closed
wants to merge 1 commit into from
Closed

fix: missing public_url configuration option #119

wants to merge 1 commit into from

Conversation

karzac
Copy link

@karzac karzac commented Oct 31, 2022

Fixes #118

@kbond
Copy link

kbond commented Oct 31, 2022

I think we should allow using a service for this option. Wdyt?

@kbond
Copy link

kbond commented Oct 31, 2022 •
edited
Loading

FYI, there is also a new TemporaryUrlGenerator (thephpleague/flysystem#1573). This should be able to be configured with a service as well. When using as a service, PublicUrlGenerator and TemporaryUrlGenerator are injected into Filesystem::__construct() directly (not as part of $config).

@norkunas norkunas mentioned this pull request Dec 12, 2022
Merged
@tgalopin
Copy link
Member

Done in #123

Thanks a lot for your PR anyway!

@tgalopin tgalopin closed this Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please add public_url option to filesystem configuration
3 participants
@karzac @kbond @tgalopin