Allow to configure public/temporary url generation #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, is there something preventing from merging this? /cc @tgalopin |
tgalopin
reviewed
Dec 26, 2022
| @@ -1,3 +1,4 @@ | |||
| framework: | |||
| secret: 'test_secret' | |||
| test: true | |||
| http_method_override: false | |||
There was a problem hiding this comment.
What's the reason for this change?
There was a problem hiding this comment.
To fix deprecation notice
tgalopin
approved these changes
Dec 26, 2022
|
Thanks @norkunas ! |
|
Can we have a new tag @tgalopin please? I have to fork the bundle to use the new 'public_url' feature for now: https://github.com/coopTilleuls/flysystem-bundle/tree/3.1.0 |
|
Thanks @tgalopin ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added 3 new options:
public_urlwhich allows to use a single url or multiple urls and basedflysystemwill resolve public url generator;public_url_generator- a string value of service id;temporary_url_generator- a string value of service id.and also added tests and fixed some deprecation in tests.
Closes #118
Replaces #119