Add the ability to configure the ignorePassiveAddress option of the FTP adapter #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks, I'll have a look! It wasn't in the documentation so I missed it (https://flysystem.thephpleague.com/docs/adapter/ftp/). If you want, you can do a PR there to add the option in the doc :) ! |
|
Done in #1028 👍 |
|
I realized when checking your PR that some FTP and SFTP tests were lacking: I took the opportunity of your PR to add them. I also renamed Thanks for your work :) ! |
This was referenced Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use FlySystem in a dockerized FTPd dev environment, I need to configure the
ignorePassiveAddressoption of the FTP Apdater. However the bundle doesn't allow us to configure this option. This PR aims to fix that.